Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): improve helpers to prevent doubts experienced in PR #680 #685

Merged
merged 15 commits into from
Aug 28, 2023

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Aug 28, 2023

Contributes to #684.

@adrienjoly adrienjoly self-assigned this Aug 28, 2023
@adrienjoly adrienjoly changed the title fix test helpers based on trouble while working on PR #680 fix(tests): improve helpers to prevent doubts experienced in PR #680 Aug 28, 2023
@codacy-production
Copy link

codacy-production bot commented Aug 28, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 8cf4daa1 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8cf4daa) Report Missing Report Missing Report Missing
Head commit (6412854) 5071 2983 58.83%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#685) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@adrienjoly adrienjoly marked this pull request as ready for review August 28, 2023 13:52
@adrienjoly adrienjoly merged commit 616cc81 into main Aug 28, 2023
18 of 19 checks passed
@adrienjoly adrienjoly deleted the fix/test-helpers branch August 28, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant