[change] Added variable to configure daphne websocket timeout #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This timeout value is also used for configuring the "group_expiry" of CHANNEL_LAYERS.
pandafy
commented
Dec 6, 2021
| @@ -2,7 +2,7 @@ | |||
| user={{ www_user }} | |||
| socket=unix://{{ openwisp2_path }}/daphne0.sock | |||
| directory={{ openwisp2_path }} | |||
| command={{ openwisp2_path }}/env/bin/daphne --fd 0 -u {{ openwisp2_path }}/daphne%(process_num)d.sock --access-log - --proxy-headers openwisp2.asgi:application | |||
| command={{ openwisp2_path }}/env/bin/daphne --fd 0 -u {{ openwisp2_path }}/daphne%(process_num)d.sock --access-log - --websocket_timeout {{ openwisp2_daphne_websocket_timeout }} --proxy-headers openwisp2.asgi:application | |||
There was a problem hiding this comment.
The default value for websocket_timeout is 24 hours. This is the maximum allowed time a websocket is allowed to stay connected. In OpenWISP, I believe 1 hour is more than enough.
nemesifier
reviewed
Dec 6, 2021
|
My previous observations were wrong. The |
nemesifier
reviewed
Dec 8, 2021
meta/main.yml
Outdated
| @@ -9,7 +9,7 @@ dependencies: | |||
| postfix_smtpd_relay_restrictions: "{{ postfix_smtpd_relay_restrictions_override }}" | |||
|
|
|||
| - src: https://github.com/openwisp/ansible-ow-influxdb | |||
| version: origin/master | |||
| version: origin/issues/3-updating-user-password | |||
There was a problem hiding this comment.
looks like this will have to be updated
pandafy
force-pushed
the
daphne-websocket-timeout
branch
from
680d417
to
b2de714
Compare
nemesifier
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This timeout value is also used for configuring the "group_expiry"
of CHANNEL_LAYERS.