Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[change] Use ReconnectingWebsocket to websocket connection #101

Closed
pandafy opened this issue Dec 9, 2021 · 0 comments · Fixed by #102
Closed

[change] Use ReconnectingWebsocket to websocket connection #101

pandafy opened this issue Dec 9, 2021 · 0 comments · Fixed by #102
Labels
good first issue
Projects
OpenWISP Contributor's Board

Comments

@pandafy
Copy link
Member

pandafy commented Dec 9, 2021

openwisp/ansible-openwisp2#321 sets the websocket_timeout of daphne to 1 hour (reducing from the 24 hours default value).
This means that the websocket connection will get terminated abruptly for users after the timeout. To prevent that use ReconnectingWebsocket from https://github.com/joewalnes/reconnecting-websocket which re-establishes the connection when the connection is terminated.

This library is already used in openwisp-notifications and openwisp-controller.
@pandafy pandafy assigned pandafy and unassigned pandafy Dec 9, 2021
@pandafy pandafy added this to To do (general) in OpenWISP Contributor's Board via automation Dec 9, 2021
@pandafy pandafy moved this from To do (general) to To do (Python & Django) in OpenWISP Contributor's Board Dec 9, 2021
yashikajotwani12 added a commit to yashikajotwani12/django-loci that referenced this issue Dec 16, 2021
@yashikajotwani12
[change] Use ReconnectingWebsocket to websocket connection openwisp#101
8cb31d7 
Fixes openwisp#101
@yashikajotwani12 yashikajotwani12 mentioned this issue Dec 16, 2021
Merged
yashikajotwani12 added a commit to yashikajotwani12/django-loci that referenced this issue Dec 28, 2021
@yashikajotwani12
[change] Use ReconnectingWebsocket to websocket connection openwisp#101
574e335 
Fixes openwisp#101
yashikajotwani12 added a commit to yashikajotwani12/django-loci that referenced this issue Jan 14, 2022
@yashikajotwani12
[change] Use ReconnectingWebsocket to websocket connection openwisp#101
ef5a0cd 
Fixes openwisp#101
yashikajotwani12 added a commit to yashikajotwani12/django-loci that referenced this issue Jan 18, 2022
@yashikajotwani12
[change] Use ReconnectingWebsocket to websocket connection openwisp#101
baa16ac 
Fixes openwisp#101
yashikajotwani12 added a commit to yashikajotwani12/django-loci that referenced this issue Jan 18, 2022
@yashikajotwani12
[change] Use ReconnectingWebsocket to websocket connection openwisp#101
0337044 
Fixes openwisp#101
yashikajotwani12 added a commit to yashikajotwani12/django-loci that referenced this issue Jan 18, 2022
@yashikajotwani12
[change] Use ReconnectingWebsocket to websocket connection openwisp#101
fc82332 
Fixes openwisp#101
OpenWISP Contributor's Board automation moved this from To do (Python & Django) to Done Jan 19, 2022
nemesifier pushed a commit that referenced this issue Jan 19, 2022
@yashikajotwani12
[change] Use ReconnectingWebsocket to websocket connection #101
b356a98 
Fixes #101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
OpenWISP Contributor's Board
Archived in project
OpenWISP Contributor's Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[change] Use ReconnectingWebsocket to websocket connection #101 yashikajotwani12/django-loci
1 participant
@pandafy