Skip to content
This repository has been archived by the owner on Sep 10, 2020. It is now read-only.

[bug] Form error on "Add batch user creation" #251

Closed
atb00ker opened this issue May 18, 2019 · 0 comments · Fixed by #252
Closed

[bug] Form error on "Add batch user creation" #251

atb00ker opened this issue May 18, 2019 · 0 comments · Fixed by #252
Labels
bug GCI Task reserved for GCI help wanted
Projects
OpenWISP Contributor's Board

Comments

@atb00ker
Copy link
Member

Error:

UnicodeDecodeError at /admin/openwisp_radius/radiusbatch/add/
'utf-8' codec can't decode byte 0xa1 in position 11: invalid start byte

How to reproduce:

  1. Go to <domain>/admin/openwisp_radius/radiusbatch/add/
  2. Select "Strategy:" as "Import from CSV"
  3. Upload a PDF file instead of CSV.

Expected Behaviour:
Graceful handling of error; telling user that incorrect format file has been uploaded and asking them to try again.
@atb00ker atb00ker transferred this issue from openwisp/openwisp-radius Nov 19, 2019
Aviral14 added a commit to Aviral14/django-freeradius that referenced this issue Nov 19, 2019
@Aviral14
[utils] Add error handling in csvfile validation
9ea790d 
Fixes openwisp#251
@Aviral14 Aviral14 mentioned this issue Nov 19, 2019
Merged
Aviral14 added a commit to Aviral14/django-freeradius that referenced this issue Nov 19, 2019
@Aviral14
[utils] Add error handling in csvfile validation
782122a 
Fixes openwisp#251

Remove extra whitespace
Aviral14 added a commit to Aviral14/django-freeradius that referenced this issue Nov 19, 2019
@Aviral14
[utils] Add error handling in csvfile validation openwisp#251
0c4baf3 
Fixes openwisp#251
Aviral14 added a commit to Aviral14/django-freeradius that referenced this issue Nov 20, 2019
@Aviral14
[utils] Add error handling in csvfile validation openwisp#251
975d939 
Fixes openwisp#251
1.Add try except blocks to catch the error
2.Add test for the same

Add test for checking invalid file format

Add dummy pdf file
Aviral14 added a commit to Aviral14/django-freeradius that referenced this issue Nov 20, 2019
@Aviral14
[utils] Add error handling in csvfile validation openwisp#251
f3b1fe3 
Fixes openwisp#251
1.Add try except blocks to catch the error
2.Add test for the same
3.Use ugettext_lazy
Aviral14 added a commit to Aviral14/django-freeradius that referenced this issue Nov 20, 2019
@Aviral14
[utils] Add error handling in csvfile validation openwisp#251
94845ed 
Fixes openwisp#251
1.Add try except blocks to catch the error
2.Add test for the same
3.Use ugettext_lazy
4.Fix Formatting in utils file
Aviral14 added a commit to Aviral14/django-freeradius that referenced this issue Nov 20, 2019
@Aviral14
[utils] Add error handling in csvfile validation openwisp#251
aedeb98 
Fixes openwisp#251
1.Add try except blocks to catch the error
2.Add test for the same
3.Use ugettext_lazy
4.Fix Formatting in utils file
Aviral14 added a commit to Aviral14/django-freeradius that referenced this issue Nov 21, 2019
@Aviral14
[utils] Add error handling in csvfile validation openwisp#251
0530d86 
Fixes openwisp#251
1.Add try except blocks to catch the error
2.Add test for the same
3.Use ugettext_lazy
4.Fix Formatting in utils file
5.Create separate method to validate file format
OpenWISP Contributor's Board automation moved this from To do (Python & Django) to Done Nov 21, 2019
@openwisp openwisp deleted a comment from khizirsiddiqui Dec 10, 2019
@openwisp openwisp deleted a comment from NoumbissiValere Dec 10, 2019
@openwisp openwisp deleted a comment from pandafy Dec 10, 2019
@atb00ker atb00ker added the GCI Task reserved for GCI label Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug GCI Task reserved for GCI help wanted
Projects
OpenWISP Contributor's Board
Archived in project
OpenWISP Contributor's Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[utils] Add error handling in csvfile validation Aviral14/django-freeradius
1 participant
@atb00ker