[Init] Initial works to split the json schema widget into a package. #1

auvipy · 2018-04-16T16:32:28Z

No description provided.

auvipy

travis config, tests and some clean up needed probably.

auvipy · 2018-05-23T10:42:43Z

jsonschema_widget/static/css/admin.css

@@ -0,0 +1,117 @@
+a.button:focus,
+a.jsoneditor-exit:focus{ text-decoration: none }


may be this should be dropped

if this code is imported from the current implementation we can leave it as is, we can deal with the UI in the next step

auvipy · 2018-05-23T11:08:27Z

@nemesisdesign could you check if this is nearby for initial merge and manual testing? some minor tweaks may be needed, I will start work on test after this is in

CONTRIBUTING.rst

docs/installation.rst

nemesifier

great progress @auvipy 👍 see my comments

nemesifier · 2018-08-27T18:54:50Z

jsonschema_widget/static/css/admin.css

@@ -0,0 +1,117 @@
+a.button:focus,
+a.jsoneditor-exit:focus{ text-decoration: none }


if this code is imported from the current implementation we can leave it as is, we can deal with the UI in the next step

docs/installation.rst

docs/index.rst

AUTHORS.rst

CONTRIBUTING.rst

docs/usage.rst

setup.py

tests/settings.py

auvipy · 2018-08-28T06:59:25Z

probably I have addressed the comments. except for sphinx. do you think this pr is ok to get in?

nemesifier

@auvipy ready for manual testing, I will test as soon as possible and added this to my TODO list.

I left some comments regarding minor improvements.

AUTHORS.rst

nemesifier · 2018-08-28T19:19:39Z

jsonschema_widget/templates/jsonschema_widget/base.html

+        {% endblock javascript %}
+
+    {% endblock extra_js %}
+{% endcomment %}


I don't get the point of this file

will take care of this after your manual testing. other comments are addressed hopefully

jsonschema_widget/urls.py

tests/urls.py

nemesifier · 2018-10-03T18:30:24Z

Will get here asap.

auvipy · 2018-10-04T11:02:12Z

OK. Looking forward to it

atb00ker

I tested it out openwisp/django-netjsonconfig#96 ; first project to use this repository looks like working ! 👍
Note: I had to make changes for Django-2.1 compatibility: https://github.com/atb00ker/django-jsonschema-widget
I have a couple of questions / comments:

Should we start with automated testing? 😄
(please read more questions below)

setup.py

manage.py

requirements.txt

atb00ker · 2018-10-29T18:04:33Z

jsonschema_widget/widgets.py

+</label>
+"""
+        html = html.format(_('Advanced mode (raw JSON)'),
+                           reverse('netjsonconfig:schema'))


Since we are moving it out of netjsonconfig, my assumption is that it's planned to be used at other places as well!
Hence, shouldn't all these values be either variables (to be set from the settings file) or changed and made generalised to keep any project in mind!
I am not only talking about the reverse here, but also values above are keeping only that one project in mind!

Please correct me if i've understood it incorrectly! 😄

I not sure right now, @nemesisdesign might have better insight than me in this regard.

@atb00ker is right, here I explain our main use cases: #2
I think we can work on this in the next iterations, for the moment let's focus on making it work properly on django-netjsonconfig, even if it's dirty (we won't release it yet).

auvipy · 2018-11-01T17:13:06Z

added Django 2.1 related changes. will start working on automated testing after this get merged initially. for automated test, which approach or tools you prefer?

nemesifier

I found Issues during manual testing on django-netjsonconfig and reported to openwisp/django-netjsonconfig#96 (review)

I propose the following: let's fix the easiest stuff (namings and conventions) and leave the harder stuff for more iterations, let's merge, I'm adding both of you to have write permissions to the repo so we can work on it together here.

We can also create some GCI tasks for improvements like using Pipenv and similar, while we focus on making the package work and get it to the point that we can issue the first release and we can merge openwisp/django-netjsonconfig#96

setup.py

tests/settings.py

manage.py

requirements.txt

requirements_test.txt

requirements_dev.txt

setup.cfg

auvipy · 2018-11-07T14:05:58Z

thanks for your review, Will fix the easier tasks first and after that will merge and start more iteration for the next concerns.

nemesifier · 2018-11-07T14:15:35Z

Great, thanks. I enabled also travis and coveralls

atb00ker · 2018-11-10T04:02:30Z

P.S: Also, the commit guidelines of the rest of the projects for consistency! 😊

auvipy · 2018-11-21T13:30:48Z

should I disable jslint check for now? or fix them all?

nemesifier

Try adding this: https://github.com/openwisp/django-netjsonconfig/blob/master/.jslintrc

auvipy · 2018-11-22T17:19:03Z

OK

auvipy · 2018-12-09T12:17:46Z

what's the reason for build failures? any hints for fixing it?

auvipy · 2018-12-09T12:25:22Z

I want to get this in and start working on automated testing

nemesifier

@auvipy thank you for pinging us, we've been super busy with the Google Code-In which is almost over now.

I left you some comments that should help you resolve the situation. Once you have done please squash the commits into one.

.travis.yml

requirements-test.txt

.travis.yml

django_jsonschema_widget/models.py

nemesifier · 2018-12-09T19:15:43Z

.travis.yml

+
+script:
+  - coverage run --source= runtests.py
+  - if [[ $TRAVIS_PYTHON_VERSION == 3.4 ]]; then ./tests/manage.py makemigrations --dry-run | grep "No changes detected"; fi


you can also remove the migration check because we don't have any model

auvipy · 2018-12-10T17:08:09Z

I will address all the issues tomorrow.

auvipy · 2018-12-12T16:13:13Z

I might have messed up something in shell section, could any of you take another look? do we need to add django as a dependency on requirements-test?

nemesifier

@auvipy is just the commit message style check doing its job, we added a check in all our modules to ensure the commit message style used is consistent so that the commit log of each project is readable

Could you please clean up the commit history of this PR so we can merge?

The fastest way is to squash all the previous commits into one and give it a message like:

[init] First commit

auvipy · 2019-03-02T07:49:26Z

I must have to do this before this week ends!!!

atb00ker · 2019-03-02T09:08:36Z

Great, thanks! 👍

auvipy added 3 commits April 16, 2018 21:59

package files

e741c91

app skeletons with widget scrapeed andd static files from netjsonconfig

48f360f

test files

4d6a921

auvipy commented May 23, 2018

View reviewed changes

auvipy added 2 commits May 23, 2018 16:51

updated tox for django 2.1 alpha1

609b704

added basic travis config

1da4b72

auvipy added 2 commits August 27, 2018 15:46

updated django version

354a1f8

small updates

56f8c08

auvipy commented Aug 27, 2018

View reviewed changes

CONTRIBUTING.rst Outdated Show resolved Hide resolved

docs/installation.rst Outdated Show resolved Hide resolved

nemesifier reviewed Aug 27, 2018

View reviewed changes

auvipy added 3 commits August 28, 2018 12:12

reviews addressed

6f2a9bf

reviews addressed

47b2f38

reviews addressed

5948f95

nemesifier reviewed Aug 28, 2018

View reviewed changes

nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation Aug 28, 2018

addressed review comments

50f7188

nemesifier moved this from To do (general) to In progress in OpenWISP Contributor's Board Sep 28, 2018

atb00ker mentioned this pull request Oct 29, 2018

Extract jsonschema-widget to separate package openwisp/django-netjsonconfig#96

Closed

atb00ker reviewed Oct 29, 2018

View reviewed changes

django 2.1 related changes in widget rendering

9984962

nemesifier reviewed Nov 7, 2018

View reviewed changes

auvipy self-assigned this Nov 7, 2018

auvipy added 4 commits November 21, 2018 18:44

renamed requirements files

d4ce4fc

moved manage.py inside tests dir

486a6b8

cleanups

5bd1f03

modified travis and tox configs

2ce816e

nemesifier reviewed Nov 21, 2018

View reviewed changes

added jslinrc config

c71844f

nemesifier mentioned this pull request Dec 8, 2018

openwisp_controller.connection module (SSH connections) openwisp/openwisp-controller#31

Merged

nemesifier reviewed Dec 9, 2018

View reviewed changes

auvipy added 6 commits December 11, 2018 12:01

removed un needed models

2cd6ceb

modified travis and test requirments

322ef46

modified travis

18cfe01

django-json_schema app to settings and remove model import in test

c644b65

shell syntax

d3e737d

shell syntax

9d131a7

nemesifier reviewed Dec 16, 2018

View reviewed changes

auvipy changed the title ~~WIP - Do not merge~~ [Init] Initial works for splitting the json schema widget Mar 2, 2019

auvipy changed the title ~~[Init] Initial works for splitting the json schema widget~~ [Init] Initial works to split the json schema widget into a package. Mar 2, 2019

auvipy added 2 commits March 3, 2019 08:36

fix typo in readme

beb92b1

fix typo in installation doc

b7893b6

auvipy merged commit 3abf6e2 into openwisp:master Mar 3, 2019

OpenWISP Contributor's Board automation moved this from In progress to Done Mar 3, 2019

nemesifier mentioned this pull request Jun 30, 2020

[admin] Extract jsonschema-widget to separate django package openwisp/openwisp-controller#214

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Init] Initial works to split the json schema widget into a package. #1

[Init] Initial works to split the json schema widget into a package. #1

auvipy commented Apr 16, 2018

auvipy left a comment

auvipy May 23, 2018

nemesifier Aug 27, 2018

auvipy Aug 28, 2018

auvipy commented May 23, 2018

nemesifier left a comment

nemesifier Aug 27, 2018

auvipy commented Aug 28, 2018

nemesifier left a comment

nemesifier Aug 28, 2018

auvipy Sep 15, 2018

nemesifier commented Oct 3, 2018

auvipy commented Oct 4, 2018

atb00ker left a comment

atb00ker Oct 29, 2018

auvipy Nov 1, 2018

nemesifier Nov 7, 2018

auvipy commented Nov 1, 2018

nemesifier left a comment

auvipy commented Nov 7, 2018

nemesifier commented Nov 7, 2018

atb00ker commented Nov 10, 2018

auvipy commented Nov 21, 2018

nemesifier left a comment

auvipy commented Nov 22, 2018

auvipy commented Dec 9, 2018

auvipy commented Dec 9, 2018

nemesifier left a comment

nemesifier Dec 9, 2018

auvipy commented Dec 10, 2018

auvipy commented Dec 12, 2018

nemesifier left a comment

auvipy commented Mar 2, 2019

atb00ker commented Mar 2, 2019

		@@ -0,0 +1,117 @@
		a.button:focus,
		a.jsoneditor-exit:focus{ text-decoration: none }

[Init] Initial works to split the json schema widget into a package. #1

[Init] Initial works to split the json schema widget into a package. #1

Conversation

auvipy commented Apr 16, 2018

auvipy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

auvipy commented May 23, 2018

nemesifier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

auvipy commented Aug 28, 2018

nemesifier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nemesifier commented Oct 3, 2018

auvipy commented Oct 4, 2018

atb00ker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

auvipy commented Nov 1, 2018

nemesifier left a comment

Choose a reason for hiding this comment

auvipy commented Nov 7, 2018

nemesifier commented Nov 7, 2018

atb00ker commented Nov 10, 2018

auvipy commented Nov 21, 2018

nemesifier left a comment

Choose a reason for hiding this comment

auvipy commented Nov 22, 2018

auvipy commented Dec 9, 2018

auvipy commented Dec 9, 2018

nemesifier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

auvipy commented Dec 10, 2018

auvipy commented Dec 12, 2018

nemesifier left a comment

Choose a reason for hiding this comment

auvipy commented Mar 2, 2019

atb00ker commented Mar 2, 2019