openwisp_controller.connection module (SSH connections)

[nemesifier]

WIP, refers to #30

[okraits]

On Debian Stretch, I additionally needed to install redis (from stretch-backports) and libsqlite3-mod-spatialite and add

SPATIALITE_LIBRARY_PATH = 'mod_spatialite'

to settings.py or local_settings.py.

I can create a PR with updated README.rst and settings.py if you want.

[nemesifier]

@okraits not sure travis would work with `SPATIALITE_LIBRARY_PATH = 'mod_spatialite' but we can try

[okraits]

@nemesisdesign So should I come up with a PR for the dependencies and settings.py?

Edit: there you are: #33

[coveralls]

Coverage decreased (-1.09%) to 98.502% when pulling 0b1fd0a on connections into 487f13f on master.

[nemesifier]

I just rebased this branch on the current master.

[nemesifier]

@okraits on the feature side it's basically ready, unfortunately there's no nice widget to enter the credentials (it's a raw text field which expects json syntax now) but shouldn't be hard to add it later, especially once this is ready: openwisp/django-jsonschema-widget#1) in the next weeks I count on adding the missing tests.
CC: @atb00ker this is the first instance in which I want to reuse the jsonschema widget outside of django-netjsonconfig, I'm talking about the admin for the Credentials model

[nemesifier]

@atb00ker this is the schema for SSH credentials. In the future we may have other ways to access devices. For example, OpenWrt has an HTTP-RPC API served by ubus. Ubiquiti AirOS also has some sort o HTTP access that allows to update the config via HTTP calls (not sure if they have an API but surely calls to their web interface can be simulated).
That's where we want to get at some point with openwisp/netjsonconfig#91

[atb00ker]

That seems great. I see a lot of things i need to learn about and i'll start with reading the same.
Thanks. 😄

[atb00ker]

Found a small typo here:

openwisp-controller/openwisp_controller/connection/connectors/ssh.py

Line 117 in c5e2863

print('# Previus command failed, aborting upgrade...')

[okraits]

Missing char: configuration

[NoumbissiValere]

@nemesisdesign Please can you review this when you have time? I will love to apply corrections if any exist

[nemesifier]

you're executing an echo on the mock ssh server and asserting the output, for what purpose?
We need to mock the command /etc/init.d/openwisp-config restart so when that command is executed in the mock ssh server it print that output, so we can then capture the output and run an assertion on it.

[NoumbissiValere]

I myself was not convinced about this test. I was running from executing this comment on the server because from your last comment, you said this command was suppose to be executed during config.full_clean() and config.save().
will try to refine it. Thanks

[nemesifier]

why is this test being removed?

[NoumbissiValere]

This was failing with Python 2.7 on travis, so i removed to deal with the most important issue before coming back to it

[NoumbissiValere]

@nemesisdesign please can you review this, have been trying to make the test pass for DJANGO="django>=1.11,<1.12" to no avail. Please can you checkout it and give me an idea. Thanks

[NoumbissiValere]

from https://realpython.com/python-mock-library/ , python2.7 doesn't know unittest.mock so travis was failing with this import. in order to make the import work for both python2 and python 3, from https://stackoverflow.com/questions/11501520/importerror-no-module-named-mock i had to use the backport which is mock rather than unittest.mock. Thus, i had to add mock to setup.py in order to enable travis install it for testing.