[WIP][Update] Django Channels #8
Conversation
atb00ker
force-pushed
the
issues/7
branch
2 times, most recently
from
74121e9
to
8050054
Compare
| @@ -0,0 +1,3 @@ | |||
| #!/bin/bash | |||
| set -e | |||
| pytest | |||
There was a problem hiding this comment.
Please note that the final new line at the end of the file is missing, you may need to configure your editor to add finalnew lines automatically
| [pytest] | ||
| DJANGO_SETTINGS_MODULE = tests.test_settings | ||
| # -- read python files format: | ||
| python_files = pytest_*.py |
There was a problem hiding this comment.
Please note that the final new line at the end of the file is missing, you may need to configure your editor to add finalnew lines automatically
| try: | ||
| from .local_settings import * | ||
| except: #noqa | ||
| pass |
There was a problem hiding this comment.
is this file really needed? local_settings is already imported in settings.py so why not use the main settings directly?
If we can avoid adding files we should do so, the less code we have to maintain, the better.
|
|
||
| script: | ||
| - coverage run --source=django_loci runtests.py | ||
| - py.test --cov=django_loci | ||
| - coverage run -a --source=django_loci runtests.py |
There was a problem hiding this comment.
so if you manage to call pytests in runtests.py we may be able to fix coverage
There was a problem hiding this comment.
The coverage from both the tests is added.
-a option in coverage run -a --source=django_loci runtests.py appends the results from tests to the results of py.test --cov=django_loci.
The problem is only with one file routing.py
| try: | ||
| user = self.scope["user"] | ||
| self.pk = self.scope['url_route']['kwargs']['pk'] | ||
| except Exception: |
There was a problem hiding this comment.
catching the generic Exception is generally a bad practice
| ''' | ||
| In channels 2.x, Websockets can only be tested | ||
| asynchronously, hence, pytest is used for these tests. | ||
| ''' |
There was a problem hiding this comment.
for consistency, use double quotes for docstrings
## Do not Merge ##
Tasks remaining before Merge:
test_update_location()with the new version of channels, i need help with it.routing.pybelong to.coveragerc, under omit section? The file is called during the tests yet that doesn't reflect in the coverage!WIP: #7
PR Forwarded, Please Read: #9