Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels 2 upgrade #9

Merged
merged 2 commits into from
Sep 2, 2018
Merged

Channels 2 upgrade #9

merged 2 commits into from
Sep 2, 2018

Conversation

nemesifier
Copy link
Member

Thank you @atb00ker for your outstanding work! I've fixed the test and performed clean up.
Let's see if the travis build passes.

Closes #7 and #8.

@nemesifier nemesifier self-assigned this Sep 2, 2018
@coveralls
Copy link

coveralls commented Sep 2, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling b731eef on channels2 into 7fe814e on master.

@atb00ker
Copy link
Member

atb00ker commented Sep 2, 2018

@nemesisdesign , the file pytest_channels.py needs to be renamed to back test_channels.py.
I changed the name because i was running the file in a different manner! Currently that file is not running, hence the decreased coverage!

@nemesifier
Copy link
Member Author

@atb00ker oh I didn't notice that.. I already changed the logic again.. but anyway, I think now it's better, the result is cleaner and I undertsood how to make sure the pytest suite runs fast (it was running very slowly in my env because the db was being recreated at each test).

What do you think? Can we merge?

@nemesifier
Copy link
Member Author

PS: coveralls now reports 100%, not sure why it hasn't posted the result here: https://coveralls.io/builds/18793941

@nemesifier nemesifier force-pushed the channels2 branch 2 times, most recently from b6d3f58 to 76d80fc Compare September 2, 2018 18:59
@atb00ker
Copy link
Member

atb00ker commented Sep 2, 2018

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest django-channels version
3 participants