DRYed GeoFeatureModelSerializer

[pglotov]

This PR is an attempt to DRY out the GeoFeatureModelSerializer: main field loop is done in the DRF base class ModelSerializer, GeoFeatureModelSerializer only re-shuffles and adds geo specific fields. Also provides hooks to modify properties field.

[nemesifier]

hi @pglotov, won't this conflict with #71?

[pglotov]

It will, but i think this is a cleaner approach since we don't duplicate field loop already present in base class, just repackage base class result and add geo specific fields which base class is not aware how to deal with. @sh4wn what do you think? Are the hooks in this PR enough for customizing properties field?

[landscape-bot]

Code quality remained the same when pulling b16f406 on pglotov:dry-serializer into f58d9c5 on djangonauts:master.

[nemesifier]

I think #71 is a good approach, the naming of the methods are clear, it includes usage documentation as requested and I don't see a duplication of the field loop. If you see any way to improve #71 leave comments there please.

[pglotov]

Compare
https://github.com/tomchristie/django-rest-framework/blob/master/rest_framework/serializers.py#L450
and
https://github.com/djangonauts/django-rest-framework-gis/blob/master/rest_framework_gis/serializers.py#L144

This is a dependency which has to be followed and acted upon if DRF class changes.

[nemesifier]

Thank you @pglotov, we can keep track of this in a new issue, could you open it?