Skip to content

Commit

Permalink
Merge pull request #13 from blag/patch-1
Browse files Browse the repository at this point in the history
Handle contrib apps
  • Loading branch information
sheppard committed May 11, 2017
2 parents 4d91bb8 + 859ecb5 commit 3b43147
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion swapper/__init__.py
Expand Up @@ -111,5 +111,5 @@ def join(app_label, model):


def split(model):
app_label, model = model.split(".")
app_label, _, model = model.rpartition(".")
return app_label, model
8 changes: 8 additions & 0 deletions tests/test_swapper.py
Expand Up @@ -49,6 +49,14 @@ def test_not_installed(self):
with self.assertRaises(ImproperlyConfigured):
swapper.load_model("invalid_app", "Invalid", required=True)

def test_non_contrib_app_split(self):
self.assertEqual(swapper.split('alt_app.Type'), ('alt_app', 'Type'))

def test_contrib_app_split(self):
self.assertEqual(
swapper.split('alt_app.contrib.named_things.NamedThing'),
('alt_app.contrib.named_things', 'NamedThing'))

# Tests that only work if default_app.Type is swapped
@unittest.skipUnless(settings.SWAP, "requires swapped models")
def test_swap_setting(self):
Expand Down
1 change: 1 addition & 0 deletions tox.ini
Expand Up @@ -29,6 +29,7 @@ deps =
setenv =
noswap: DJANGO_SETTINGS_MODULE=tests.settings
swap: DJANGO_SETTINGS_MODULE=tests.swap_settings
whitelist_externals = rm

[testenv:lint]
commands =
Expand Down

0 comments on commit 3b43147

Please sign in to comment.