Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle contrib apps #13

Merged
merged 4 commits into from
May 11, 2017
Merged

Handle contrib apps #13

merged 4 commits into from
May 11, 2017

Conversation

blag
Copy link
Contributor

@blag blag commented Jan 3, 2017

And apps with dots in their app_label.

Currently:

'django.contrib.comments.Comment' -> ('django', 'contrib', 'comments', 'Comment')

With this change:

'django.contrib.comments.Comment' -> ('django.contrib.comments', 'Comment')

@blag blag force-pushed the patch-1 branch 2 times, most recently from 4ff4e8a to 8f6634f Compare April 24, 2017 09:34
@monotonee
Copy link

monotonee commented May 10, 2017

@sheppard I, too, would be very grateful if you would approve and merge this pull request. I was about to make an identical fix but happily, blag beat me to it.

Until this issue is fixed, we are also unable to specify a model in a subpackage or submodule such as myapp.subpackage.Model.

@sheppard sheppard merged commit 3b43147 into openwisp:master May 11, 2017
@sheppard
Copy link
Collaborator

Sorry, this slipped off my radar. Merged and released as 1.1.0.

@blag
Copy link
Contributor Author

blag commented May 11, 2017

No worries, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants