[schema] Validate dns_search hostname format #42

openwisp · Apr 4, 2016 · f1116f0 · f1116f0
1 parent abb63bd
commit f1116f0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/netjsonconfig/schema.py b/netjsonconfig/schema.py
@@ -699,7 +699,8 @@
             "propertyOrder": 5,
             "items": {
                 "title": "Domain",
-                "type": "string"
+                "type": "string",
+                "format": "hostname"
             }
         },
         "routes": {

diff --git a/tests/openwrt/test_formats.py b/tests/openwrt/test_formats.py
@@ -73,3 +73,13 @@ def test_ntp_servers_hostname(self):
         o.config['ntp']['server'][0] = 'totally/wrong'
         with self.assertRaises(ValidationError):
             o.validate()
+
+    def test_dns_search_hostname(self):
+        o = OpenWrt({
+            "dns_search": ['openwisp.org', 'test.netjson.org']
+        })
+        o.validate()
+        # invalid hostname
+        o.config['dns_search'].append('very/wrong')
+        with self.assertRaises(ValidationError):
+            o.validate()