Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed type mismatch error #123

Closed
wants to merge 0 commits into from
Closed

fixed type mismatch error #123

wants to merge 0 commits into from

Conversation

yasharora102
Copy link
Contributor

No description provided.

nemesifier
nemesifier requested changes Nov 22, 2018
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test is missing (read the review I left on #119), rebase on the current master please

@yasharora102
Copy link
Contributor Author

@nemesisdesign can you tell an example of the test you are talking about?

nemesifier
nemesifier reviewed Nov 23, 2018
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stealthflame you have to write a test that replicates the issue (then apply the patch and ensure it's fixed), it's full examples in this repository

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.724% when pulling 76f7656 on stealthflame:issue118 into e2843d7 on openwisp:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.724% when pulling 76f7656 on stealthflame:issue118 into e2843d7 on openwisp:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yasharora102 @coveralls @nemesifier