[bug] Fix switch vlan ordering #104 #149
Conversation
atb00ker
changed the title
atb00ker
changed the title
There was a problem hiding this comment.
Thanks for the fix Ajay, it works!
From a purely coding related point of view, it is not 100% correct, see my comment below, but I'm going to fix this now in order to speed it up.
PS: here's the improvement: 5182887
| @@ -109,6 +109,19 @@ def to_netjson(self, remove_block=True): | |||
| # return result, expects dict | |||
| return result | |||
|
|
|||
| def clean_intermediate_data(self, intermediate_data): | |||
There was a problem hiding this comment.
you're adding a fix for the OpenWrt backend in the Base converter.
Base classes are supposed to be generic.
I am going to handle this issue on my own. Thanks for the fix.
There was a problem hiding this comment.
That was actually a conscious decision, I thought other backends like (openwisp 1.X) will need this change as well, however, I have not worked with any other backend, so I might have misunderstood it incorrectly.
Thanks for the information! 😄
There was a problem hiding this comment.
OpenWrt derivatives will have to install OpenWrt base classes.
Don't forget it's possible to implement backends for non-openwrt systems.
We implemented two experimental backends in the past:
- https://github.com/openwisp/netjsonconfig/tree/raspbian
- https://github.com/openwisp/netjsonconfig/tree/airos
The goal of OpenWISP is to support multiple systems.
I found that the issue #104 is because the order of the list items is causing problems,
switch_vlanis defined and processed beforeswitchwhich is causingKeyErroras switch itself is not existing at the timeswitch_vlanis being processed.This pull request solves the problem by reordering the intermediate list.
Closes #104
Please let me know if there is a better way to solve this issue!