Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typo] Fix minor typo in raise TypeError #157

Merged
merged 1 commit into from
May 29, 2020
Merged

[typo] Fix minor typo in raise TypeError #157

merged 1 commit into from
May 29, 2020

Conversation

fredrikblau
Copy link
Contributor

Fix minor typo in raise TypeError #151

@fredrikblau fredrikblau mentioned this pull request May 29, 2020
Closed
@coveralls
Copy link

coveralls commented May 29, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 99.932% when pulling 60537ad on AmirAhrari:issues/151 into 9adc849 on openwisp:master.

@PabloCastellano PabloCastellano changed the title [typo] Fix minor typo in raise TypeError https://github.com/openwisp/… [typo] Fix minor typo in raise TypeError May 29, 2020
PabloCastellano
PabloCastellano previously approved these changes May 29, 2020
View reviewed changes
Copy link

@PabloCastellano PabloCastellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

atb00ker
atb00ker requested changes May 29, 2020
View reviewed changes
Copy link
Member

@atb00ker atb00ker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit follows the guidelines, which is great, can you please add Closes #<issue> in the commit's message as well! 😄

Also, please check the small change suggested below, thanks! 😄

netjsonconfig/backends/base/backend.py Outdated Show resolved Hide resolved
nemesifier
nemesifier approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nemesifier nemesifier merged commit 2e9338d into openwisp:master May 29, 2020
@fredrikblau fredrikblau deleted the issues/151 branch May 29, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atb00ker atb00ker atb00ker requested changes

@nemesifier nemesifier nemesifier approved these changes

@PabloCastellano PabloCastellano PabloCastellano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fredrikblau @coveralls @PabloCastellano @nemesifier @atb00ker