[openvpn] Add option proto to remote setting #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okraits
added this to Ready for review/testing
in OpenWISP Priorities for next releases
okraits
force-pushed
the
add-proto-to-remote
branch
from
a52ff1a
to
d95ad84
Compare
|
@nemesisdesign Anything keeping this one from getting merged? |
nemesifier
reviewed
Nov 10, 2021
OpenWISP Priorities for next releases
automation
moved this from Ready for review/testing
to Reviewer approved
Mar 12, 2022
nemesifier
approved these changes
Mar 12, 2022
There was a problem hiding this comment.
@okraits I implemented a small change in your patch for the following reason:
If the user adds a remote, they would have been asked again which protocol to use, but that information is already been asked above, so the default for the new proto attribute is "auto" which will be ignored and will allow the system to continue as if it was not present, but at the same time it will be possible to override it if needed.
Result in OW-controller:
For me it's good to be merged now, let me know what you think.
|
@nemesisdesign Yes, that sounds like a reasonable solution. Thank you for fixing the issue! |
OpenWISP Priorities for next releases
automation
moved this from Reviewer approved
to Done
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.