[change] Update dependencies #203 #206
Conversation
There was a problem hiding this comment.
Please can you also update the dependency monitoring service as done in openwisp/openwisp-utils@243f119?
There was a problem hiding this comment.
Please also update the other outdated deps, see https://libraries.io/github/openwisp/netjsonconfig#repository_dependencies.
Yeah, sure I will. 👍🏻 |
There was a problem hiding this comment.
@yashikajotwani12 the latest version of jsonschema is 4.4.0. We should update that as well.
netjsonconfig/requirements.txt
Lines 1 to 3 in ca737e3
@nemesisdesign I think it will be save to remove six from the requirements. What do you think?
|
I checked through the docs and have updated jsonschema to the latest version, but here 3 tests are failing. |
yashikajotwani12
force-pushed
the
issue-203
branch
from
00436f8
to
c92cb14
Compare
updated the other outdated deps Fixes openwisp#203
The hostname validation has been adapted from jsonschema~=3.2.0 (jsonschema._format.is_host_name). The newer versions of jsonschema enforces FQDN validation which is not always required in OpenWISP. E.g. setting up hostname of a device.
|
I have fixed the failing tests. @yashikajotwani12 see 98d2ea4. Thank you for contributing. 😄 |
pandafy
added this to In progress
in OpenWISP Priorities for next releases
via automation
pandafy
moved this from In progress
to Ready for review/testing
in OpenWISP Priorities for next releases
.github/workflows/ci.yml
Outdated
| @@ -11,7 +11,7 @@ on: | |||
|
|
|||
| jobs: | |||
| build: | |||
| name: Python==${{ matrix.python-version }} | |||
| name: Python==${{ matrix.python-version }} | ${{ matrix.django-version }} | |||
There was a problem hiding this comment.
@yashikajotwani12 why did you made this change? This module is not dependent on Django.
There was a problem hiding this comment.
Maybe I made it by mistake, I will take care next time, Thanks for the information
| for component in components: | ||
| if len(component) > 63: | ||
| return False | ||
| return True |
Fixes #203