[fix] Fixed optional management frame protection #264 #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
added this to In progress
in OpenWISP Priorities for next releases
via automation
nemesifier
force-pushed
the
issues/264-mfp-optional
branch
from
9b93b54
to
2e7d548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264
@pandafy this change here looks like a mistake, which I am fixing in this PR:
e696759a#diff-83e7f712c7b8a94dcf6a0acb84af4a1566db59ada5e3ecae57ab6f487ec93bd0L483-L485
The "optional" option was removed but the corresponding "enum_titles" was not. However, the section in the schema is named "encryption_mfp_property_optional" so it doesn't make a lot of sense to remove the possibility of setting MFP to "optional".
Let me know if you think that was not a mistake and give us more explanation.