Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doc on template ordering #64

Merged
merged 2 commits into from
Mar 6, 2017
Merged

Added doc on template ordering #64

merged 2 commits into from
Mar 6, 2017

Conversation

ritwickdsouza
Copy link
Contributor

References #62
Please let me know if any changes needs to be made. :)

@coveralls
Copy link

coveralls commented Mar 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ad4f9e3 on ritwickdsouza:ordering-templates into 5fc47f9 on openwisp:master.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Please improve formatting as suggested. Test your changes locally with by doing:

cd docs
make html

And check the generated HTML looks good.

@@ -171,6 +171,8 @@ Template
If you have devices with very similar *configuration dictionaries* you can store the shared
blocks in one or more reusable templates which will be used as a base to build
the final configuration.
When using multiple templates, their order is important.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a new line before the sentence, plus a note sign, like:

If you have devices with very similar *configuration dictionaries* you can store the shared blocks in one or more reusable templates which will be used as a base to build the final configuration.
 
.. note::
    when using multiple templates, their order is important.
    Templates that come afterwards overrides the templates that come before it.

@coveralls
Copy link

coveralls commented Mar 6, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 7d5fcfd on ritwickdsouza:ordering-templates into 5fc47f9 on openwisp:master.

@ritwickdsouza
Copy link
Contributor Author

@nemesisdesign Any more changes required ?

@nemesifier
Copy link
Member

Looks good.

@nemesifier nemesifier merged commit d71412f into openwisp:master Mar 6, 2017
@ritwickdsouza ritwickdsouza deleted the ordering-templates branch March 6, 2017 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants