[qa] Remove bad code practices #129 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totallynotvaishnav
added this to In progress
in [GSoC 22] netjsongraph.js
via automation
totallynotvaishnav
force-pushed
the
issues/129-remove-bad-practices
branch
from
140d9fc
to
d0d1c53
Compare
nemesifier
requested changes
Jun 18, 2022
.editorconfig
Outdated
| @@ -9,3 +9,4 @@ end_of_line = lf | |||
| charset = utf-8 | |||
| trim_trailing_whitespace = true | |||
| insert_final_newline = true | |||
| quote_type = single | |||
There was a problem hiding this comment.
why this? We don't have this in https://github.com/openwisp/openwisp-wifi-login-pages/blob/master/.editorconfig .
We can keep double quotes I believe.
There was a problem hiding this comment.
I thought it would be nice to have single quotes as we are using single quotes on other modules. I will change it back.
nemesifier
moved this from Review in progress
to In progress
in [GSoC 22] netjsongraph.js
nemesifier
requested changes
Jun 18, 2022
totallynotvaishnav
force-pushed
the
issues/129-remove-bad-practices
branch
from
d0d1c53
to
abc6dfb
Compare
totallynotvaishnav
force-pushed
the
issues/129-remove-bad-practices
branch
from
abc6dfb
to
34afec4
Compare
nemesifier
approved these changes
Jun 21, 2022
[GSoC 22] netjsongraph.js
automation
moved this from Review in progress
to Reviewer approved
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #129