Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[change] Remove bad code practices #129

Closed
totallynotvaishnav opened this issue Jun 10, 2022 · 0 comments
Closed

[change] Remove bad code practices #129

totallynotvaishnav opened this issue Jun 10, 2022 · 0 comments

Comments

@totallynotvaishnav
Copy link
Member

totallynotvaishnav commented Jun 10, 2022 •
edited
Loading

Right now, pretty much most of the code violates the rules set by eslint. We must rewrite the code that violates these rules to ensure good practices are followed.

See #121 (review)
@totallynotvaishnav totallynotvaishnav mentioned this issue Jun 13, 2022
Merged
totallynotvaishnav added a commit that referenced this issue Jun 17, 2022
@totallynotvaishnav
[qa] Remove bad code practices #129
2929cce 
closes #129
@totallynotvaishnav totallynotvaishnav mentioned this issue Jun 17, 2022
Merged
totallynotvaishnav added a commit that referenced this issue Jun 20, 2022
@totallynotvaishnav
[qa] Remove bad code practices #129
e605d18 
closes #129
nemesifier pushed a commit that referenced this issue Jun 21, 2022
@totallynotvaishnav
[qa] Fixed linting settings #129
ee92d3b 
Closes #129
totallynotvaishnav added a commit that referenced this issue Jul 9, 2022
@totallynotvaishnav
[qa] Fixed linting settings #129
766b2f6 
Closes #129
totallynotvaishnav added a commit to totallynotvaishnav/netjsongraph.js that referenced this issue Nov 15, 2022
@totallynotvaishnav
[qa] Fixed linting settings openwisp#129
05585e9 
Closes openwisp#129
totallynotvaishnav added a commit that referenced this issue Nov 16, 2022
@totallynotvaishnav
[qa] Fixed linting settings #129
70ad879 
Closes #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nemesifier @totallynotvaishnav