Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qa] Add a dedicated run-qa-checks script #148

Closed
2 tasks
devkapilbansal opened this issue Oct 7, 2021 · 2 comments · Fixed by #155
Closed
2 tasks

[qa] Add a dedicated run-qa-checks script #148

devkapilbansal opened this issue Oct 7, 2021 · 2 comments · Fixed by #155
Labels
good first issue hacktoberfest

Comments

@devkapilbansal
Copy link
Member

We should check for the syntax of shell scripts too and format them to maintain consistency.

  • Add shell formatter and Lua formatter
  • Use a dedicated run-qa-checks script to maintain consistency with other repos

I had done similar work in openwrt-openwisp-monitoring that can be used as a reference
@Aryamanz29
Copy link
Member

I would like to give it a try @devkapilbansal

@devkapilbansal
Copy link
Member Author

Sure @Aryamanz29
Feel free to ask here or on public channel in case of doubts.

devkapilbansal added a commit that referenced this issue Nov 30, 2021
@devkapilbansal
[qa] Added lua formatter #148
4911061 
Closes #148
@devkapilbansal devkapilbansal mentioned this issue Nov 30, 2021
Merged
devkapilbansal added a commit that referenced this issue Nov 30, 2021
@devkapilbansal
[qa] Added lua formatter #148
a488675 
Closes #148
devkapilbansal added a commit that referenced this issue Dec 2, 2021
@devkapilbansal
[qa] Added lua formatter #148
21358d6 
Closes #148
devkapilbansal added a commit that referenced this issue Dec 4, 2021
@devkapilbansal
[qa] Added lua formatter #148
269bbcc 
Closes #148
pandafy pushed a commit that referenced this issue Dec 28, 2021
@devkapilbansal @pandafy
[qa] Added lua formatter #148
f4379be 
Closes #148
pandafy pushed a commit that referenced this issue Dec 29, 2021
@devkapilbansal @pandafy
[qa] Added lua formatter #148
7ac64eb 
Closes #148
pandafy pushed a commit that referenced this issue Jan 5, 2022
@devkapilbansal @pandafy
[qa] Added shell and lua formatter #148
477d250 
- Added shellcheck

Closes #147
Closes #148
pandafy pushed a commit that referenced this issue Jan 5, 2022
@devkapilbansal @pandafy
[qa] Added shell and lua formatter #147 #148
724edad 
- Added shellcheck

Closes #147
Closes #148
pandafy added a commit that referenced this issue Jan 5, 2022
@devkapilbansal @pandafy
[qa] Added shell and lua formatter #147 #148
903388c 
- Added shellcheck

Closes #147
Closes #148

Co-authored-by: Gagan Deep <pandafy.dev@gmail.com>
devkapilbansal added a commit that referenced this issue Jan 12, 2022
@devkapilbansal @pandafy
[qa] Added shell and lua formatter #147 #148
f77c83d 
- Added shellcheck

Closes #147
Closes #148

Co-authored-by: Gagan Deep <pandafy.dev@gmail.com>
nemesifier added a commit that referenced this issue Jan 24, 2022
@devkapilbansal @pandafy @nemesifier
[qa] Add qa checks and formatting #147 #148
b150e65 
Closes #147
Closes #148

Co-authored-by: Gagan Deep <pandafy.dev@gmail.com>
Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[qa] Add qa checks and formatting #147 #148 openwisp/openwisp-config
2 participants
@devkapilbansal @Aryamanz29