Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Removing VPN template should not delete related certificate #827

Closed
pandafy opened this issue Feb 5, 2024 · 0 comments · Fixed by #833
Closed

[feature] Removing VPN template should not delete related certificate #827

pandafy opened this issue Feb 5, 2024 · 0 comments · Fixed by #833
Assignees
@pandafy
Labels
enhancement
Projects
OpenWISP Priorities for next releases

Comments

@pandafy
Copy link
Member

pandafy commented Feb 5, 2024

Removing a VPN (OpenVPN) template from the device should not delete the related certificate. Instead, the certificate should be flagged as revoked.

We need to develop this feature such that it could be also used when deactivating the device (#625)
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation Feb 5, 2024
@nemesifier nemesifier moved this from Backlog to To do in OpenWISP Priorities for next releases Feb 5, 2024
pandafy added a commit that referenced this issue Feb 9, 2024
@pandafy
[feature] Removing VPN template will not delete related Cert #827
3883965 
Removing VPN template from a device will dekete rekated Cert object.
Instead, it will mark the certificate as revoked.

Closes #827
@pandafy pandafy mentioned this issue Feb 9, 2024
Merged
pandafy added a commit that referenced this issue Feb 9, 2024
@pandafy
[feature] Removing VPN template will not delete related Cert #827
60f3bd2 
Removing VPN template from a device will dekete rekated Cert object.
Instead, it will mark the certificate as revoked.

Closes #827
pandafy added a commit that referenced this issue Feb 29, 2024
@pandafy
[feature] Removing VPN template will not delete related Cert #827
3433c2b 
Removing VPN template from a device will not delete the related
Cert object. Instead, it will mark the certificate as revoked.

Closes #827
pandafy added a commit that referenced this issue Feb 29, 2024
@pandafy
[feature] Removing VPN template will not delete related Cert #827
35c918a 
Removing VPN template from a device will dekete rekated Cert object.
Instead, it will mark the certificate as revoked.

Closes #827
nemesifier pushed a commit that referenced this issue Mar 4, 2024
@pandafy
[change] Removing VPN template will not delete related Cert #827
8a73eaa 
Removing VPN template from a device will not delete the related
Cert object. Instead, it will mark the certificate as revoked.

Closes #827
OpenWISP Priorities for next releases automation moved this from To do to Done Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pandafy pandafy

Labels
enhancement
Projects
OpenWISP Priorities for next releases
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feature] Removing VPN template will not delete related Cert #827 openwisp/openwisp-controller
2 participants
@nemesifier @pandafy