Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Removing VPN template will not delete related Cert #827 #833

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Feb 9, 2024

Removing VPN template from a device will not delete related Cert object. Instead, it will mark the certificate as revoked.

Closes #827

@pandafy pandafy force-pushed the issues/827-vpnclient-revoke-certificate branch from 3883965 to 60f3bd2 Compare February 9, 2024 15:14
@coveralls
Copy link

coveralls commented Feb 9, 2024

Coverage Status

coverage: 99.015%. remained the same
when pulling 3433c2b on issues/827-vpnclient-revoke-certificate
into 60b9478 on master.

Removing VPN template from a device will not delete the related
Cert object. Instead, it will mark the certificate as revoked.

Closes #827
@pandafy pandafy force-pushed the issues/827-vpnclient-revoke-certificate branch from 60f3bd2 to 3433c2b Compare February 29, 2024 12:00
@nemesifier nemesifier merged commit 8a73eaa into master Mar 4, 2024
10 checks passed
@nemesifier nemesifier deleted the issues/827-vpnclient-revoke-certificate branch March 4, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[feature] Removing VPN template should not delete related certificate
3 participants