Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing migration #40

Closed
wants to merge 2 commits into from
Closed

Added missing migration #40

wants to merge 2 commits into from

Conversation

rhblind
Copy link

@rhblind rhblind commented Sep 18, 2018

This PR adds a missing migration file for the config app

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.583% when pulling d8c29f3 on inonit:master into cc7e9ff on openwisp:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.583% when pulling d8c29f3 on inonit:master into cc7e9ff on openwisp:master.

@nemesifier
Copy link
Member

@rhblind thank you for contributing. The issue was solved in a development branch which I forgot to merge in master (see #41). Sorry for that. I merged it now so this is not needed anymore.
If you want to use the current master you will need to use the latest django-netjsonconfig, install it with

pip install https://github.com/openwisp/django-netjsonconfig/tarball/master

@nemesifier nemesifier closed this Sep 18, 2018
@rhblind
Copy link
Author

rhblind commented Sep 18, 2018

Thanks a bunch! 👍

@rhblind
Copy link
Author

rhblind commented Sep 18, 2018

@nemesisdesign I'm getting warning when using the master branch of django-netjsonconfig.

openwisp-controller 0.3.2 has requirement django-netjsonconfig<0.9.0,>=0.8.0, but you'll have django-netjsonconfig 0.9a0
 which is incompatible.

@nemesifier
Copy link
Member

@rhblind the version of the master of openwisp-controller is 0.4.0a and should not give you this warning, try and let me know

@rhblind
Copy link
Author

rhblind commented Sep 19, 2018

@nemesisdesign Thanks, that worked good! Do you have any plans for a new release soon so that we don't have to rely on master branch versions?

@nemesifier
Copy link
Member

nemesifier commented Sep 19, 2018

@rhblind not very soon unfortunately, 0.4.0 must include #31 which is almost complete but needs more test coverage and will take me a while to do because I'm focused on django-freeradius and openwisp-radius right now. I suggest you to pin the commit ID for now. Are you using ansible-openwisp2 to install? If yes you can use openwisp2_controller_pip: https://github.com/openwisp/openwisp-controller/tarball/df98881b8f04a1dbbabb0dc10e39cd0f36f4ec33, you should do the same for django-netjsonconfig (pin the commit in the conf).

@rhblind
Copy link
Author

rhblind commented Sep 19, 2018

@nemesisdesign Alright, no worries! We haven't really decided deployment strategy yet, but thanks for the tips! Keep up the good work 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants