Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Avoid error logging to print noisy output during tests #118

Closed
pandafy opened this issue Jan 23, 2021 · 6 comments · Fixed by #175
Closed

[test] Avoid error logging to print noisy output during tests #118

pandafy opened this issue Jan 23, 2021 · 6 comments · Fixed by #175
Labels
good first issue Good for newcomers Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Milestone

Comments

@pandafy
Copy link
Member

pandafy commented Jan 23, 2021

Run tests (notice it outputs a lot of things)

 $ ./runtests.py 
Creating test database for alias 'default'...
System check identified no issues (0 silenced).
.............................................................{'device': ['Device Firmware with this Device already exists.']}
................................................SoftTimeLimitExceeded raised in batch_upgrade_operation task
..SoftTimeLimitExceeded raised in upgrade_firmware task
.

Checkout the following functions:


Take reference from openwisp/openwisp-controller#366

@pandafy pandafy added the good first issue Good for newcomers label Jan 23, 2021
@b-thebest
Copy link

hello, Can I take up this issue and work on it?

@devkapilbansal
Copy link
Member

Sure @b-thebest, go ahead

@b-thebest
Copy link

@devkapilbansal I have one small doubt. Should I remove full stop logging on console also or only errors ?

@devkapilbansal
Copy link
Member

It would be better if you can remove those dots too.

@nemesifier
Copy link
Member

Wait a minute, for the dots you mean ..........? That's the standard behavior and we should not remove it @devkapilbansal @b-thebest

@RahulPalve
Copy link

RahulPalve commented Mar 14, 2021

hey, I want to work on this, It appears that extra verbose msgs are from logging

RahulPalve added a commit to RahulPalve/openwisp-firmware-upgrader that referenced this issue Mar 14, 2021
Avoid error logging to print noisy output during tests,
disabled logging during test enabled after tests
Fixes openwisp#118
@nemesifier nemesifier added the Hacktoberfest Easy issues for attracting Hacktoberfest participants. label Oct 1, 2021
@pandafy pandafy added this to the Release 0.2.0 milestone Jan 26, 2022
Aryamanz29 added a commit to Aryamanz29/openwisp-firmware-upgrader that referenced this issue Feb 3, 2022
Used openwisp-utils @capture_any_output() to avoid noisy
error logging output during tests, Closes openwisp#118
nemesifier pushed a commit that referenced this issue Feb 15, 2022
Used openwisp-utils @capture_any_output() to avoid noisy
output during tests.

Closes #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
Archived in project
5 participants