Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Non shared subnet overlapping with shared subnet is not catched as a validation error #88

Closed
nemesifier opened this issue Mar 24, 2021 · 0 comments · Fixed by #89
Closed

[bug] Non shared subnet overlapping with shared subnet is not catched as a validation error #88

nemesifier opened this issue Mar 24, 2021 · 0 comments · Fixed by #89
Assignees
@nemesifier
Labels
bug Something isn't working
Projects
OpenWISP Priorities for next releases

Comments

@nemesifier
Copy link
Member

When two subnets, one shared and one non shared overlap, the validation does not catch it but it should.
@nemesifier nemesifier added the enhancement New feature or request label Mar 24, 2021
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation Mar 24, 2021
@nemesifier nemesifier self-assigned this Mar 24, 2021
nemesifier added a commit that referenced this issue Mar 24, 2021
@nemesifier
[fix] Fix overlapping shared/non-shared subnet validation #88
4388a25 
Fixes #88
@nemesifier nemesifier mentioned this issue Mar 24, 2021
Merged
@nemesifier nemesifier added bug Something isn't working and removed enhancement New feature or request labels Mar 24, 2021
OpenWISP Priorities for next releases automation moved this from Backlog to Done Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nemesifier nemesifier

Labels
bug Something isn't working
Projects
OpenWISP Priorities for next releases
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Fix overlapping shared/non-shared subnet validation #88 openwisp/openwisp-ipam
1 participant
@nemesifier