Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix overlapping shared/non-shared subnet validation #88 #89

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

nemesifier
Copy link
Member

Fixes #88

@nemesifier nemesifier added the bug Something isn't working label Mar 24, 2021
@nemesifier nemesifier self-assigned this Mar 24, 2021
@nemesifier nemesifier force-pushed the issues/88-overlapping-shared-subnets branch from 4388a25 to 03b6a28 Compare April 5, 2021 21:11
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 99.381% when pulling 03b6a28 on issues/88-overlapping-shared-subnets into 8cf050d on master.

@nemesifier nemesifier merged commit 03b6a28 into master Apr 5, 2021
@atb00ker atb00ker deleted the issues/88-overlapping-shared-subnets branch January 21, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Non shared subnet overlapping with shared subnet is not catched as a validation error
2 participants