Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] Find out what to do with compatibility shims for ipaddress library #96

Closed
nemesifier opened this issue Apr 15, 2021 · 1 comment · Fixed by #127
Closed

[cleanup] Find out what to do with compatibility shims for ipaddress library #96

nemesifier opened this issue Apr 15, 2021 · 1 comment · Fixed by #127
Labels
enhancement New feature or request Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
OpenWISP Contributor's Board OpenWISP Priorities for next releases

Comments

@nemesifier
Copy link
Member

The coverage build shows that the compatibility shims for ipaddress library are not being executed anymore:
https://coveralls.io/jobs/78517731/source_files/7752510585

Maybe we can remove those, but before doing so we have to understand why this is happening. Maybe the ipaddress library has been updated on recent minor versions updates of python 3.6?
@nemesifier nemesifier added the enhancement New feature or request label Apr 15, 2021
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation Apr 15, 2021
@nemesifier nemesifier added this to To do general in Roadmap via automation Apr 15, 2021
@nemesifier nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation Apr 15, 2021
@nemesifier nemesifier mentioned this issue Apr 15, 2021
Merged
@nemesifier nemesifier removed this from To do general in Roadmap Sep 18, 2021
@nemesifier nemesifier added the Hacktoberfest Easy issues for attracting Hacktoberfest participants. label Sep 26, 2021
@nemesifier nemesifier moved this from To do (general) to To do (Python & Django) in OpenWISP Contributor's Board Oct 1, 2021
@pandafy
Copy link
Member

pandafy commented Jan 4, 2022

Since Python 3.6 is EOL and we are removing support for Python 3.6, we can simply remove the shim. 😄

pandafy added a commit that referenced this issue Jan 4, 2022
@pandafy
[deps!] Upgraded Django and dropped support for Python 3.6 #117
7924142 
- Dropped support for Python 3.6
- Added support for Django 3.2 and Django 4.0
- Bumped xlrd~2.0.1
- Bumped django-reversion~=4.0.1

Closes #96
Closes #102
Closes #120
Closes #117

**Backward incompatible change**: Subnets with /32 prefixlen
can provision an IP address same as the network address.
pandafy added a commit that referenced this issue Jan 4, 2022
@pandafy
[deps!] Upgraded Django and dropped support for Python 3.6 #117
d27aa60 
- Dropped support for Python 3.6
- Added support for Django 3.2 and Django 4.0
- Bumped xlrd~=2.0.1
- Bumped django-reversion~=4.0.1

Closes #96
Closes #102
Closes #120
Closes #117

**Backward incompatible change**: Subnets with /32 prefixlen
can provision an IP address same as the network address.
@pandafy pandafy mentioned this issue Jan 4, 2022
Merged
pandafy added a commit that referenced this issue Jan 4, 2022
@pandafy
[deps!] Upgraded Django and dropped support for Python 3.6 #117
e762eeb 
- Dropped support for Python 3.6
- Added support for Django 3.2 and Django 4.0
- Replaced xlrd with openpyxl
- Bumped django-reversion~=4.0.1

Closes #96
Closes #102
Closes #120
Closes #117

**Backward incompatible change**: Subnets with /32 prefixlen
can provision an IP address same as the network address.
pandafy added a commit that referenced this issue Jan 4, 2022
@pandafy
[deps!] Upgraded Django and dropped support for Python 3.6 #117
20f8e94 
- Dropped support for Python 3.6
- Added support for Django 3.2 and Django 4.0
- Replaced xlrd with openpyxl
- Bumped django-reversion~=4.0.1

Closes #96
Closes #102
Closes #120
Closes #117

**Backward incompatible change**: Subnets with /32 prefixlen
can provision an IP address same as the network address.
pandafy added a commit that referenced this issue Jan 5, 2022
@pandafy
[deps!] Upgraded Django and dropped support for Python 3.6 #117
8059208 
- Dropped support for Python 3.6
- Added support for Django 3.2 and Django 4.0
- Replaced xlrd with openpyxl
- Bumped django-reversion~=4.0.1

Closes #96
Closes #102
Closes #120
Closes #117

**Backward incompatible change**: Subnets with /32 prefixlen
can provision an IP address same as the network address.
pandafy added a commit that referenced this issue Jan 5, 2022
@pandafy
[deps!] Upgraded Django and dropped support for Python 3.6 #117
fcd297d 
- Dropped support for Python 3.6
- Added support for Django 3.2 and Django 4.0
- Replaced xlrd with openpyxl
- Bumped django-reversion~=4.0.1

Closes #96
Closes #102
Closes #120
Closes #117

**Backward incompatible change**: Subnets with /32 prefixlen
can provision an IP address same as the network address.
pandafy added a commit that referenced this issue Jan 5, 2022
@pandafy
[deps!] Upgraded Django and dropped support for Python 3.6 #117
891e7de 
- Dropped support for Python 3.6
- Added support for Django 3.2 and Django 4.0
- Replaced xlrd with openpyxl
- Bumped django-reversion~=4.0.1

Closes #96
Closes #102
Closes #120
Closes #117

**Backward incompatible change**: Subnets with /32 prefixlen
can provision an IP address same as the network address.
pandafy added a commit that referenced this issue Jan 5, 2022
@pandafy
[deps!] Upgraded Django and dropped support for Python 3.6 #117
556a53c 
- Dropped support for Python 3.6
- Added support for Django 3.2 and Django 4.0
- Replaced xlrd with openpyxl
- Bumped django-reversion~=4.0.1

Closes #96
Closes #102
Closes #120
Closes #117

**Backward incompatible change**: Subnets with /32 prefixlen
can provision an IP address same as the network address.
OpenWISP Contributor's Board automation moved this from To do (Python & Django) to Done Jan 5, 2022
OpenWISP Priorities for next releases automation moved this from Backlog to Done Jan 5, 2022
nemesifier added a commit that referenced this issue Jan 5, 2022
@pandafy @nemesifier
[deps] Upgraded Django and dropped support for Python 3.6 #117
4f15237 
- Dropped support for Python 3.6
- Added support for Django 3.2 and Django 4.0
- Replaced xlrd with openpyxl
- Bumped django-reversion~=4.0.1

Closes #96
Closes #102
Closes #120
Closes #117

Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
OpenWISP Contributor's Board
  
Done
OpenWISP Priorities for next releases
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[deps!] Upgraded Django and dropped support for Python 3.6 #117 openwisp/openwisp-ipam
2 participants
@nemesifier @pandafy