[deps!] Upgraded Django and dropped support for Python 3.6 #117 #127
Conversation
pandafy
force-pushed
the
issues/117-django-deps
branch
from
d27aa60
to
e762eeb
Compare
pandafy
force-pushed
the
issues/117-django-deps
branch
from
bec750a
to
8c10389
Compare
pandafy
force-pushed
the
issues/117-django-deps
branch
2 times, most recently
from
8059208
to
fcd297d
Compare
pandafy
force-pushed
the
issues/117-django-deps
branch
from
fcd297d
to
891e7de
Compare
| if file.name.endswith(('.xls', '.xlsx')): | ||
| book = xlrd.open_workbook(file_contents=file.read()) | ||
| sheet = book.sheet_by_index(0) | ||
| row = [] | ||
| for row_num in range(sheet.nrows): | ||
| row.append(sheet.row_values(row_num)) | ||
| reader = iter(row) | ||
| if file.name.endswith(('.xlsx')): | ||
| book = openpyxl.load_workbook(filename=file) | ||
| sheet = book.worksheets[0] | ||
| reader = sheet.values |
There was a problem hiding this comment.
Earlier the project was using xlrd package for reading xls and xlsx files. But the latest version of xlrd now only processes xls files. Hence, I swapped the package for openxlpy which can read xlsx files (but not xls files). I changed the dependency with the thought that more and more people will be using xlsx files in the current time.
We can look for other alternatives if we really want to support xls files.
There was a problem hiding this comment.
Right now we can do CSV and XLSX.
The library for parsing CSV is ships with Python. (no external library/package is required)
For parsing XLSX we will be using openxlpy
With this PR, we will be dropping support for XLS. Should we also drop support for XLSX?
I believe dropping support for XLSX might make our lives easier.
There was a problem hiding this comment.
it's fine as it is, let's not touch this further right now, there's no reason to.
- Dropped support for Python 3.6 - Added support for Django 3.2 and Django 4.0 - Replaced xlrd with openpyxl - Bumped django-reversion~=4.0.1 Closes #96 Closes #102 Closes #120 Closes #117 **Backward incompatible change**: Subnets with /32 prefixlen can provision an IP address same as the network address.
pandafy
force-pushed
the
issues/117-django-deps
branch
from
3936e7a
to
c26d316
Compare
Closes #96
Closes #102
Closes #120
Closes #117
Backward incompatible change: Subnets with /32 prefixlen
can provision an IP address same as the network address.