[ci] Added Github CI Build #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devkapilbansal
force-pushed
the
github-ci-build
branch
3 times, most recently
from
a4682ee
to
ea1f4a2
Compare
|
So reordering some classes fix the error. 🤔 Thanks for the help @purhan 😄 |
|
@devkapilbansal The build previously failed because of this change: openwisp/openwisp-users#230. |
nemesifier
approved these changes
Mar 6, 2021
nemesifier
requested changes
Mar 6, 2021
There was a problem hiding this comment.
Thanks @devkapilbansal, the travis config file has to be removed though, can you please do that?
nemesifier
reviewed
Mar 6, 2021
devkapilbansal
force-pushed
the
github-ci-build
branch
from
073f0b1
to
11e1828
Compare
Closes #85
devkapilbansal
force-pushed
the
github-ci-build
branch
from
11e1828
to
9af3d19
Compare
devkapilbansal
added this to In progress
in OpenWISP Priorities for next releases
via automation
devkapilbansal
moved this from In progress
to Ready for review/testing
in OpenWISP Priorities for next releases
atb00ker
approved these changes
Mar 9, 2021
| @@ -1,5 +1,5 @@ | |||
| # TODO: change this when next version of openwisp_users is released | |||
| openwisp-users @ https://github.com/purhan/openwisp-users/tarball/master | |||
| openwisp-users @ https://github.com/openwisp/openwisp-users/tarball/master | |||
There was a problem hiding this comment.
@purhan was there a reason for using your fork or was this a mistake? 😄
| @@ -6,6 +6,10 @@ echo '' | |||
| echo 'Check JavaScript Linting' | |||
| jslint ./openwisp_ipam/static/openwisp-ipam/js/*.js | |||
|
|
|||
| echo '' | |||
| echo 'Check CSS Linting' | |||
| stylelint ./openwisp_ipam/static/openwisp-ipam/css/*.css | |||
There was a problem hiding this comment.
Perhaps we should move something like this in openwisp-utils and run it on all modules! 😄
OpenWISP Priorities for next releases
automation
moved this from Ready for review/testing
to Reviewer approved
Mar 11, 2021
nemesifier
approved these changes
Mar 11, 2021
OpenWISP Priorities for next releases
automation
moved this from Reviewer approved
to Done
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.