Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qa] Fix permission classes in API #84

Merged
merged 1 commit into from
Mar 6, 2021
Merged

[qa] Fix permission classes in API #84

merged 1 commit into from
Mar 6, 2021

Conversation

purhan
Copy link
Contributor

@purhan purhan commented Mar 6, 2021

Tests are failing because of a change in openwisp/openwisp-users#230
This PR will fix it.

@devkapilbansal
Copy link
Member

@purhan the similar changes are made in #83 Then why this PR is needed??

@purhan
Copy link
Contributor Author

purhan commented Mar 6, 2021 •
edited
Loading

@purhan the similar changes are made in #83 Then why this PR is needed??

I think this is more urgent currently. We should remove the changes from that PR and rebase to this one later, these are unrelated to that one. Also I noticed there's no issue to move this repository to github actions.

nemesifier
nemesifier approved these changes Mar 6, 2021
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @purhan 👍

@nemesifier nemesifier merged commit ddc10a7 into master Mar 6, 2021
@purhan purhan deleted the fix-api-filter-permission branch March 6, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees

@purhan purhan

Labels
None yet
Projects
OpenWISP Priorities for next releases
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@purhan @devkapilbansal @nemesifier