Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Do not call update_status directly if any check is present #165

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

nemesifier
Copy link
Member

@nemesifier nemesifier commented Jul 16, 2020

Added recovery argument to allow to be used also as a way to signal device issues.
Needed for openwisp/openwisp-network-topology#75

Added mention of this integration in the README.
Will test this manually soon and then merge.

Checks:

  • I have manually tested the proposed changes
  • I have written new test cases to avoid regressions (if necessary)
  • I have updated the documentation (e.g. README.rst)

@nemesifier nemesifier added bug Something isn't working enhancement New feature or request labels Jul 16, 2020
@nemesifier nemesifier requested a review from nepython July 16, 2020 17:55
@nemesifier nemesifier self-assigned this Jul 16, 2020
@nemesifier nemesifier force-pushed the trigger-device-checks-improvement branch from 2d7cd74 to cb3097e Compare July 16, 2020 18:35
Copy link
Contributor

@nepython nepython left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants