Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Added WiFi 6 client capability #492 #509

Merged
merged 4 commits into from
May 15, 2023
Merged

[feature] Added WiFi 6 client capability #492 #509

merged 4 commits into from
May 15, 2023

Conversation

Aryamanz29
Copy link
Member

Depends on: #506

Screenshot from 2023-04-20 19-44-29

Screenshot from 2023-04-20 19-44-47

Screenshot from 2023-04-20 19-44-37

Screenshot from 2023-04-20 19-44-29

Closes #492

Checks:

  • I have manually tested the proposed changes
  • I have written new test cases to avoid regressions (if necessary)
  • I have updated the documentation (e.g. README.rst)

@Aryamanz29 Aryamanz29 added the enhancement New feature or request label Apr 20, 2023
@Aryamanz29 Aryamanz29 self-assigned this Apr 20, 2023
@Aryamanz29 Aryamanz29 marked this pull request as ready for review April 20, 2023 15:20
@coveralls
Copy link

coveralls commented Apr 20, 2023 •
edited

Coverage Status

Coverage: 99.111% (+0.005%) from 99.106% when pulling b06613c on issue-492/add-wifi-6-capability into 1510b48 on master.

nemesifier
nemesifier reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get #506 merged so then you can rebase this branch.

@Aryamanz29 Aryamanz29 force-pushed the issue-492/add-wifi-6-capability branch from 968e63e to 6c3ff63 Compare April 21, 2023 09:48
@Aryamanz29 Aryamanz29 force-pushed the issue-492/add-wifi-6-capability branch from 6c3ff63 to b06613c Compare April 21, 2023 15:32
nemesifier
nemesifier requested changes May 2, 2023
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress @Aryamanz29, please see my comments below.

openwisp_monitoring/device/base/models.py Show resolved Hide resolved
openwisp_monitoring/device/tasks.py Outdated Show resolved Hide resolved
@Aryamanz29 Aryamanz29 force-pushed the issue-492/add-wifi-6-capability branch from 0c2e199 to 62ea6ef Compare May 5, 2023 12:39
@Aryamanz29 Aryamanz29 requested a review from nemesifier May 5, 2023 13:06
@Aryamanz29 Aryamanz29 force-pushed the issue-492/add-wifi-6-capability branch from cbed830 to 9d3dd3a Compare May 5, 2023 13:49
@Aryamanz29
Copy link
Member Author

@nemesisdesign Once #515 is merged, we can rebase this PR.

@nemesifier nemesifier merged commit 342b807 into master May 15, 2023
17 checks passed
@nemesifier nemesifier deleted the issue-492/add-wifi-6-capability branch May 15, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees

@Aryamanz29 Aryamanz29

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature/change] Add WiFi 6 client capability
3 participants
@Aryamanz29 @coveralls @nemesifier