Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Flagged the HT/VHT field of WiFi clients as null #351 #506

Merged
merged 2 commits into from
Apr 21, 2023
Merged

[feature] Flagged the HT/VHT field of WiFi clients as null #351 #506

merged 2 commits into from
Apr 21, 2023

Conversation

Aryamanz29
Copy link
Member

@Aryamanz29 Aryamanz29 commented Apr 4, 2023 •
edited
Loading

Pages

Device

Screenshot from 2023-04-04 17-17-14

Wifi Session Inline

Screenshot from 2023-04-04 17-17-05

Wifi Session List

Screenshot from 2023-04-04 16-00-03

Wifi Session Change

Screenshot from 2023-04-04 15-59-20

Closes #351

Checks:

  • I have manually tested the proposed changes
  • I have written new test cases to avoid regressions (if necessary)
  • I have updated the documentation (e.g. README.rst)

@Aryamanz29 Aryamanz29 added the enhancement New feature or request label Apr 4, 2023
@Aryamanz29 Aryamanz29 self-assigned this Apr 4, 2023
@coveralls
Copy link

coveralls commented Apr 4, 2023 •
edited
Loading

Coverage Status

Coverage: 99.106% (+0.2%) from 98.895% when pulling 1510b48 on issue-351/flag-ht-vht-null into 25e00a2 on master.

@Aryamanz29 Aryamanz29 marked this pull request as ready for review April 4, 2023 12:32
@Aryamanz29
Copy link
Member Author

I think there is some bug from Django's end. Getting a similar error on the master branch too.

(env) ➜  tests git:(master) py manage.py runserver
from django.conf import DEFAULT_STORAGE_ALIAS, settings
ImportError: cannot import name 'DEFAULT_STORAGE_ALIAS' from 'django.conf' (/openwisp-monitoring/env/lib/python3.8/site-packages/django/conf/__init__.py)

@Aryamanz29 Aryamanz29 mentioned this pull request Apr 20, 2023
Merged
3 tasks
nemesifier
nemesifier approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 👍

nemesifier
nemesifier requested changes Apr 20, 2023
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aryamanz29 please squash the commits except the CI fix which is better to show as a separate commit, then we can merge.

@Aryamanz29
[feature] Flagged the HT/VHT field of WiFi clients as null #351
85da50b 
If HT/VHT is not being used, set the HT/VHT field
of WiFi clients to None. This is necessary because
some clients may be VHT capable but VHT is not enabled
at the radio level, which can lead to false information.

Closes #351
@Aryamanz29
[ci/fix] Explicitly uninstall Django before installing required version
1510b48 
In the "Install test dependencies" step,
the CI installs Django 4.2, which results in an
"ImportError: cannot import name 'DEFAULT_STORAGE_ALIAS' from 'django.conf'".
during the QA checks step.

To avoid this, we need to explicitly uninstall
Django before installing the required version.
@nemesifier nemesifier merged commit 1510b48 into master Apr 21, 2023
@nemesifier nemesifier deleted the issue-351/flag-ht-vht-null branch April 21, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

@pandafy pandafy pandafy left review comments

Assignees

@Aryamanz29 Aryamanz29

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] If not using HT/VHT, flag the HT/VHT field of WiFi clients as null
4 participants
@Aryamanz29 @coveralls @nemesifier @pandafy