-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Flagged the HT/VHT
field of WiFi clients as null #351
#506
Conversation
c4cb2b9
to
73f5438
Compare
4d9714b
to
92ac579
Compare
92ac579
to
20f2a56
Compare
20f2a56
to
59e2e3a
Compare
I think there is some bug from Django's end. Getting a similar error on the master branch too. (env) ➜ tests git:(master) py manage.py runserver
from django.conf import DEFAULT_STORAGE_ALIAS, settings
ImportError: cannot import name 'DEFAULT_STORAGE_ALIAS' from 'django.conf' (/openwisp-monitoring/env/lib/python3.8/site-packages/django/conf/__init__.py) |
59e2e3a
to
8b0192e
Compare
tests/openwisp2/sample_device_monitoring/migrations/0003_alter_wificlient_field_ht_vht.py
Outdated
Show resolved
Hide resolved
edfc6ad
to
453f93f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aryamanz29 please squash the commits except the CI fix which is better to show as a separate commit, then we can merge.
If HT/VHT is not being used, set the HT/VHT field of WiFi clients to None. This is necessary because some clients may be VHT capable but VHT is not enabled at the radio level, which can lead to false information. Closes #351
In the "Install test dependencies" step, the CI installs Django 4.2, which results in an "ImportError: cannot import name 'DEFAULT_STORAGE_ALIAS' from 'django.conf'". during the QA checks step. To avoid this, we need to explicitly uninstall Django before installing the required version.
4517710
to
1510b48
Compare
Pages
Device
Wifi Session Inline
Wifi Session List
Wifi Session Change
Closes #351
Checks: