Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Fix visualizer quirks with big topologies #164

Closed
nemesifier opened this issue Mar 6, 2023 · 2 comments · Fixed by #176
Closed

[change] Fix visualizer quirks with big topologies #164

nemesifier opened this issue Mar 6, 2023 · 2 comments · Fixed by #176

Comments

@nemesifier
Copy link
Member

When the topology is big, the initial animation is too long, moreover, dragging the nodes causes the long animation to start again, making the graph unusable.

In my testing, I found out that the following works to get rid of the animation issue:

graphConfig: {
  series: {
    force: {
      layoutAnimation: false,
    },
    draggable: false
  }
}

I guess that for any graph which has more than 20 nodes we can apply these settings.

I believe we have to fetch the JSON data in a separate request, count how many nodes there are and based on that supply this additional config.

If there's more than 50 nodes, I would also supply edgeLength: 250 to the force layout settings.

@totallynotvaishnav
Copy link
Member

I guess that for any graph which has more than 20 nodes we can apply these settings.

I believe we have to fetch the JSON data in a separate request, count how many nodes there are and based on that supply this additional config.

If there's more than 50 nodes, I would also supply edgeLength: 250 to the force layout settings.

I think it is better to do this in the netjsongraph itself. What do you think?

@nemesifier
Copy link
Member Author

I guess that for any graph which has more than 20 nodes we can apply these settings.
I believe we have to fetch the JSON data in a separate request, count how many nodes there are and based on that supply this additional config.
If there's more than 50 nodes, I would also supply edgeLength: 250 to the force layout settings.

I think it is better to do this in the netjsongraph itself. What do you think?

As discussed via IM, at the moment it's safer to implement and iterate this here, if we get to a satisfactory result which we are 100% sure makes sense to implement as default in netjsongraph.js we will follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants