[change] Moved DeviceNode data migration to create_device_nodes management command #92 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoumbissiValere
force-pushed
the
issue-92-DeviceNode-management-command
branch
from
c8b3721
to
d711d1e
Compare
nemesifier
requested changes
Sep 18, 2020
There was a problem hiding this comment.
Great @NoumbissiValere, see below a few requests for improvement.
openwisp_network_topology/integrations/device/management/commands/__init__.py
Show resolved
Hide resolved
NoumbissiValere
force-pushed
the
issue-92-DeviceNode-management-command
branch
2 times, most recently
from
8eb893d
to
c7edafe
Compare
NoumbissiValere
force-pushed
the
issue-92-DeviceNode-management-command
branch
from
c7edafe
to
773e6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92