Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[network-topology] Replace DeviceNode data migration with management command #92

Closed
nemesifier opened this issue Sep 6, 2020 · 0 comments · Fixed by #94
Closed

[network-topology] Replace DeviceNode data migration with management command #92

nemesifier opened this issue Sep 6, 2020 · 0 comments · Fixed by #94

Comments

@nemesifier
Copy link
Member

nemesifier commented Sep 6, 2020

When using the integration with openwisp-controller, instead of using a data migration to create the initial DeviceNode objects, we should use a management command, because the logic to create the initial DeviceNode objects is in a method which cannot be used during a migration because concrete models cannot be used during data migrations without risking future issues when adding/removing fields.

We'll also need to add a few lines in the readme regarding this command (when to use it and an example).

@nemesifier nemesifier added this to To do in OpenWISP Priorities for next releases via automation Sep 6, 2020
@nemesifier nemesifier added this to To do general in Roadmap via automation Sep 6, 2020
@nemesifier nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation Sep 6, 2020
@nemesifier nemesifier moved this from To do (general) to To do (Python & Django) in OpenWISP Contributor's Board Sep 6, 2020
@nemesifier nemesifier moved this from To do general to To do (Network Monitoring) in Roadmap Sep 6, 2020
@NoumbissiValere NoumbissiValere self-assigned this Sep 17, 2020
OpenWISP Contributor's Board automation moved this from To do (Python & Django) to Done Sep 18, 2020
OpenWISP Priorities for next releases automation moved this from To do to Done Sep 18, 2020
Roadmap automation moved this from To do (Network Monitoring) to Done Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment