-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] Registered menu groups #260 #270
Conversation
0214fdc
to
1d7cf40
Compare
286f83a
to
d765cb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, not sure if radius-token also needs to be registered, I'll wait for Fed to confirm that, but the rest looks good! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem exists in the PR: openwisp/openwisp-users#254 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's how I think we should order this:
- RADIUS (let's call it RADIUS not Freeradius)
- Accounting Sessions (I'd try another icon)
- Groups (icon is good)
- NAS (icon is good)
- Checks (icon is good)
- Replies (icon looks good)
- Batch User Creation (icon is good)
- Post Auth Log (can you look if you can find another icon which is more suited to indicate logs?)
For accounting sessions, what about an icon like the following?
We need an icon that conveys the idea of a list of numbers, accounting sessions contain the information of when and how users accessed the nework, how much traffic they generated, when the session started and ended and why (if they logged out explicitly or if the session went into idle timeout), the mac address of their device and the device which they used to connect, etc. This is one of the most important pieces of information of this module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 👍
I'll be doing more testing before merging.
d566551
to
81a5a21
Compare
Good work. Am new to this project, how can I use this project to manage my WISP business? Kindly assist |
Thanks @kamissah To use openWISP you can start with the documentation https://openwisp.io/docs/user/quickstart.html You can also ask your doubts in the group chat https://gitter.im/openwisp/general |
Changes
Registered menu groups
Checklist
closes #260