Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Registered menu groups #260 #270

Merged
merged 8 commits into from
Aug 1, 2021

Conversation

niteshsinha17
Copy link
Member

Changes

Registered menu groups

Checklist

  • I have read the contributing guidelines.
  • I have manually tested the proposed changes.
  • I have written new test cases to avoid regressions. (if necessary)
  • I have updated the documentation. (e.g. README.rst)

closes #260

@coveralls
Copy link

coveralls commented Jun 18, 2021

Coverage Status

Coverage increased (+0.08%) to 99.387% when pulling 6af5c91 on issues/260-register-menu-groups into b056dc2 on master.

@niteshsinha17 niteshsinha17 force-pushed the issues/260-register-menu-groups branch 2 times, most recently from 0214fdc to 1d7cf40 Compare June 30, 2021 09:55
openwisp_radius/apps.py Show resolved Hide resolved
@niteshsinha17 niteshsinha17 force-pushed the issues/260-register-menu-groups branch 2 times, most recently from 286f83a to d765cb3 Compare July 7, 2021 16:20
atb00ker
atb00ker previously approved these changes Jul 12, 2021
Copy link
Member

@atb00ker atb00ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure if radius-token also needs to be registered, I'll wait for Fed to confirm that, but the rest looks good! 😄

requirements.txt Outdated Show resolved Hide resolved
Copy link
Member

@atb00ker atb00ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem exists in the PR: openwisp/openwisp-users#254 (comment)

@niteshsinha17 niteshsinha17 self-assigned this Jul 12, 2021
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's how I think we should order this:

  • RADIUS (let's call it RADIUS not Freeradius)
    • Accounting Sessions (I'd try another icon)
    • Groups (icon is good)
    • NAS (icon is good)
    • Checks (icon is good)
    • Replies (icon looks good)
    • Batch User Creation (icon is good)
    • Post Auth Log (can you look if you can find another icon which is more suited to indicate logs?)

For accounting sessions, what about an icon like the following?

income

We need an icon that conveys the idea of a list of numbers, accounting sessions contain the information of when and how users accessed the nework, how much traffic they generated, when the session started and ended and why (if they logged out explicitly or if the session went into idle timeout), the mac address of their device and the device which they used to connect, etc. This is one of the most important pieces of information of this module.

openwisp_radius/apps.py Outdated Show resolved Hide resolved
openwisp_radius/apps.py Outdated Show resolved Hide resolved
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 👍
I'll be doing more testing before merging.

nemesifier
nemesifier previously approved these changes Jul 29, 2021
@niteshsinha17 niteshsinha17 force-pushed the issues/260-register-menu-groups branch from d566551 to 81a5a21 Compare July 29, 2021 15:32
@nemesifier nemesifier merged commit 6d64851 into master Aug 1, 2021
@nemesifier nemesifier deleted the issues/260-register-menu-groups branch August 1, 2021 16:36
@kamissah
Copy link

kamissah commented Sep 1, 2021

Good work. Am new to this project, how can I use this project to manage my WISP business? Kindly assist

@niteshsinha17
Copy link
Member Author

Thanks @kamissah To use openWISP you can start with the documentation https://openwisp.io/docs/user/quickstart.html You can also ask your doubts in the group chat https://gitter.im/openwisp/general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] Register menu groups
5 participants