Added commit message style check #23

ppabcd · 2018-11-21T16:31:46Z

Google Code-in Task : https://codein.withgoogle.com/dashboard/task-instances/5188396768034816/

prefix not present, eg: Done something (should be [qa] Done something)
no capital letter after prefix: [qa] done something
unnecessary final dot in first line, eg: [qa] Done something.
No blank line before first line and second line
Mentions an issue without closing it
Closes an issue in the long description but doesn't mention it in the short description

Fixes #20

coveralls · 2018-11-21T16:38:12Z

Coverage remained the same at 92.857% when pulling fc795fc on ppabcd:master into 951ce45 on openwisp:master.

coveralls · 2018-11-21T16:38:13Z

Coverage remained the same at 92.857% when pulling fc795fc on ppabcd:master into 951ce45 on openwisp:master.

coveralls · 2018-11-21T16:38:13Z

Coverage increased (+2.7%) to 95.556% when pulling 0c25272 on ppabcd:master into 951ce45 on openwisp:master.

nemesifier

See this feature which was added by @atb00ker :

We want to create something similar which we can reuse in other repositories too. That's the goal.

If something is not clear ask questions here.

ppabcd · 2018-11-21T22:16:00Z

ok i'll try to move my code.

KylaCommit · 2018-11-22T02:59:43Z

You have errors with commit message:

No mention issues in the short description

atb00ker · 2018-11-22T08:22:20Z

@nemesisdesign @ppabcd
I think an easier way to solve this problem is using the travis environment variables: TRAVIS_COMMIT and TRAVIS_COMMIT_MESSAGE and preforming simple regex tests.
If the regex expression doesn't match, we can simply fail the build and print a message there.

I feel this is a bit complicated way to solve this problem. What do you guys think?

ppabcd · 2018-11-22T08:26:39Z

maybe i'll try debug TRAVIS_COMMIT_MESSAGE and checked output of this env. I'm using \n for explode message, is this env output with \n maybe i can using it.

nemesifier · 2018-11-22T10:31:37Z

@atb00ker sounds good.

Let's keep in mind we'll have to implement this check in .travis.yml using a trick like this one:
https://denysdovhan.com/building-pull-requests-using-travis/

We want this check to run only on pull-requests, because once a commit is done on master, with the new branch protection rules in place we can't change it (that means admins will have to be forced to use more and more development branches and avoid working on master, which is a good thing).

nemesifier

@ppabcd in case you are wondering what means "mentions an issue without closing it", the example I had given was the following: Implements #20; this example won't close the issue #20, because only the keywords fix, fixes, close and closes do it.

Another example is: Closes #20 and #21; this won't close #21 because #21 is not preceded with the keyword which closes the issue.

But we want to allow writing something like Related to #33, because sometimes we
may want to just reference an issue even though we are not solving it in that commit.

That means that your algorithm should look for patterns which contain a hashtag preceded by a space and followed by a number and a space, eg: #<number>, and if that pattern is not preceded with any of the following keywords (case insensitive check) it should raise an error: fix, fixes, close, closes, rel, related to, ref, refers to.

Please also make sure you collect all the errors in a list and only stop execution once all the checks have been done, that way when you stop execution you can list all the errors that have been found.

nemesifier

@ppabcd overall you're doing great Reza, keep improving it with our feedback and we'll achieve this goal as well and our test suites will become very robust and we won't need to spend so much time with trivial reviews anymore, that's really good! 👍

nemesifier · 2018-11-22T10:41:06Z

setup.py

@@ -33,7 +33,8 @@
    packages=find_packages(exclude=['tests', 'docs']),
    entry_points={
        'console_scripts': [
-            'checkmigrations = openwisp_utils.qa:check_migration_name'
+            'checkmigrations = openwisp_utils.qa:check_migration_name',
+            'commitcheck = openwisp_utils.qa:check_commit_message',


use checkcommit for consistency

nemesifier · 2018-11-22T10:42:44Z

tests/test_project/tests/test_qa.py


 MIGRATIONS_DIR = path.join(path.dirname(path.dirname(path.abspath(__file__))), 'migrations')


 class TestQa(TestCase):
    _test_migration_file = '%s/0002_auto_20181001_0421.py' % MIGRATIONS_DIR
+    _gh_token = os.environ["GH_TOKEN"]
+    _repo = os.environ["TRAVIS_REPO_SLUG"]
+    _commit = os.environ["TRAVIS_COMMIT"]


I don't think you need to do this here, you need to supply your own test values directly

nemesifier · 2018-11-22T10:43:28Z

tests/test_project/tests/test_qa.py

+    def test_qa_call_check_commit_message_pass(self):
+        options = [
+            'commitcheck', '--token', self._gh_token,
+            '--commit', self._commit,


it's ok to hardcode values here, you should test all the pass cases that we mentioned in the discussion

nemesifier · 2018-11-22T10:43:36Z

tests/test_project/tests/test_qa.py

+        options = [
+            [
+                'commitcheck', '--token', self._gh_token,
+                '--commit', self._commit,


it's ok to hardcode values here, you should test all the failure cases that we mentioned in the discussion

ppabcd · 2018-11-22T14:54:13Z

openwisp_utils/qa.py

+
+    if not args.token:
+        if "GH_TOKEN" in os.environ:
+            github_token = os.environ["GH_TOKEN"]


I don't know how to coverage this line in travis

feels wrong to have this, why you can't just pass that token as argument when calling the script instead?
This check shouldn't know anything about tokens

nemesifier

@ppabcd Feels a lot more complex than what's really needed.

I think the check should take a string that represents the commit message and check just that.
In travis we can find a way to get the commit message and pass it somehow to the check.

Focus on the logic which checks the commit message right now.
Calling the github API is not really needed.

nemesifier · 2018-11-22T22:19:56Z

openwisp_utils/qa.py

+
+def check_commit_message():
+    args = _commit_check_args()
+


remove blank line (increase line-height of your editor if you feel the need of doing this)

nemesifier · 2018-11-22T22:21:54Z

openwisp_utils/qa.py

+
+    if not args.token:
+        if "GH_TOKEN" in os.environ:
+            github_token = os.environ["GH_TOKEN"]


feels wrong to have this, why you can't just pass that token as argument when calling the script instead?
This check shouldn't know anything about tokens

nemesifier · 2018-11-22T22:23:44Z

tests/test_project/tests/test_qa.py

@@ -44,5 +44,70 @@ def test_qa_call_check_migration_name_failure(self):
                else:
                    self.fail('SystemExit or Exception not raised')

+    def test_qa_call_check_commit_message_pass(self):
+        options = [
+            'commitcheck', '--token', os.environ["GH_TOKEN"],


you should fake the token during tests

nemesifier · 2018-11-22T22:24:15Z

tests/test_project/tests/test_qa.py

+    def test_qa_call_check_commit_message_pass(self):
+        options = [
+            'commitcheck', '--token', os.environ["GH_TOKEN"],
+            '--commit', os.environ["TRAVIS_COMMIT"],


what is --commit the commit message? Or the commit hash?

commit hash

nemesifier · 2018-11-22T22:24:34Z

tests/test_project/tests/test_qa.py

+        options = [
+            'commitcheck', '--token', os.environ["GH_TOKEN"],
+            '--commit', os.environ["TRAVIS_COMMIT"],
+            '--repo', os.environ["TRAVIS_REPO_SLUG"]


if you apply my suggestion of using git log -1 you don't need this

KylaCommit · 2018-11-23T17:00:49Z

You have errors with commit message:

Do not add a final dot at the end of the first line.
No mention issues in the short description
No blank line before first line and second line

KylaCommit · 2018-11-23T17:06:37Z

You have errors with commit message:

Do not add a final dot at the end of the first line.
No mention issues in the short description
No blank line before first line and second line

KylaCommit · 2018-11-23T17:10:22Z

All check done, no errors.

ppabcd · 2018-11-23T19:11:33Z

I get more problem :

In travis-ci.org i can't access commit title. You can see different here with my travis
I can't create encrypted GH_TOKEN and now i disable comment notification and only return travis errors.
No blank line before first line and second line I see when you added title Test with description Testing Commit. Github will create commit messages like this.

Testing

Testing Commit

is you mean first line and second line in description?

I am currently looking for an algorithm Mentions an issue without closing it. Because i don't have much experience in regex.

nemesifier

Good progress.

Please address my comments, clean up the code, fix the travis build, squash the commits and update the PR.
We will help you to finish the PR with more suggestion but the code is too messy now.

nemesifier · 2018-11-25T12:15:53Z

.travis.yml

-  - "3.5"
-  - "2.7"
+- '3.5'
+- '2.7'


don't chenge these lines please

nemesifier · 2018-11-25T12:16:07Z

.travis.yml

@@ -33,12 +36,12 @@ install:
  - pip install -e .[users] .[qa]

 before_script:
-  - ./runflake8
-  - ./runisort
+  - "./runflake8"


don't change these lines please

nemesifier · 2018-11-25T12:16:14Z

.travis.yml


 branches:
  only:
-    - master
+  - master


don't change these lines please

nemesifier · 2018-11-25T12:16:30Z

.travis.yml

+  - python: '2.7'
+    env: DJANGO="django>=2.0,<2.1"
+  - python: '2.7'
+    env: DJANGO="django>=2.1,<2.2"


don't change these lines please

nemesifier · 2018-11-25T12:16:47Z

.travis.yml


 env:
+  # Secure ENV Vars
+  secure: d75/sJr04cAnKgJ9JJvZZVWwRzxczNE5UfMXnluaYllraApX03NZugrv4RBp60RtUm/Sa1uv6uZiv1Xvw0VArGvNk/HvL9/FTw7riqA/YulsxNd2Hy3xyvmn4tAkbQGI0VIRh1TmFDx3DQLw/DZJ72DZDee3YWqzSO+W+z9Zs9QP6UjiiIepc6fi1+pZ6jeIn9iqg7PlVJG5QOBH0oLNA0scSWLlueyDhXR+7nteXFQ4IyA9EVPMzcUjv0kVsUCbsMDYJj3JstfuTq+mjoFbrzwX8Ey4mfLIaWpL4pXjL0i6ErZuT36l5Q0pGog/5+snKAJy02BVC9rmt0sX2IWBmWTa2fQhEZ20X9vO3/jYYbttmnYIxQVGWqMaco6e+ktxjBtL+00tMabv6z9taYGsR3b5UEWJYZGi3AENLrYuYrlp9SFUWMwRDWhaTm180DjIvdQDOzMwkmH+aEMnex3kqeF56dwyoIMhJIhg6I27PbsHkbkc9wNrPP9PN1Rke0PRsYbSx8QLQWGifCf30bJ/gZNwp41mdczgll6QNvdP6LcxE/aN0q3f/zD0XceP70G1klMOTAgzJZF6YxMkx64at+35wwaIpHBE+UpPfmI4uj2FMZgb5lWISWkJIR6Z9P5yAtSZ/CtFNTTRwohd0nflEO67od5+C18M3u9weoSXz5U=


if this is not used, remove it

nemesifier · 2018-11-25T12:17:43Z

openwisp_utils/qa.py

+    # if not args.token:
+    #     raise Exception("CLI arguement `token` is required "
+    #                     "but not found")
+    if not args.repo:


do we still need this argument?

this argument will be deleted

nemesifier · 2018-11-25T12:20:19Z

tests/test_project/tests/test_qa.py

+            # '--token',
+            # os.environ["GH_TOKEN"],
+            '--repo', os.environ["TRAVIS_REPO_SLUG"],
+            '--message', os.environ['TRAVIS_COMMIT_MESSAGE']


please stop using environment variables, remove all of them and use hardcoded test values, you are testing your implementation here, not doing the actual check with the live commit. The test needs to be stable and replicable.

Write some sample commit messages that will pass the check

ok i'll try

These are all good commit messages, use these ones as starting point

[qa] Minor clean up operations

(it's ok to not reference any issue sometimes)

[qa] Improved Y #2 Related to #2

(but if an issue is mentioned it should be specified whether the commit fixes it or just references it)

[qa] Finished task #2 Closes #2 Related to #1

(multiple references can be added in the extended desc)

These commit messages must not fail.

nemesifier

I get more problem :

In travis-ci.org i can't access commit title. You can see different here with my travis
I can't create encrypted GH_TOKEN and now i disable comment notification and only return travis errors.

Don't worry, remove all of this. You don't need to access the commit title from travis.

No blank line before first line and second line I see when you added title Test with description Testing Commit. Github will create commit messages like this.
Testing

Testing Commit
is you mean first line and second line in description?

Testing is the first line (aka short description)

Testing Commit is the second line (aka extended commit description)

There must be a blank line between the two.

I am currently looking for an algorithm Mentions an issue without closing it. Because i don't have much experience in regex.

Try the the following:

use a pattern that allows you to find out where #<issue-number> are located in the extended description (don't look in the short description because we allow to simply write #<issue-number> there
when you find occurrences of the pattern, for each pattern do the following:
- find out at which length of the text they occur
- use the length you just found to slice the text from the beginning to the end of the pattern you have found
- split the words using spaces, parts = text.split(' ')
- the last element, part[-1] should be the issue reference (#<issue-number>), while part[-2] should be the word that precedes it
- check if the preceding word is allowed, eg:

allowed_words = ['fix',
                 'fixes',
                 'close',
                 'closes',
                 'related to',
                 'refers to',
                 'ref',
                 'rel']
word = part[-2]
if word.lower() not in allowed_words:
   # fail here..

nemesifier

more comments

nemesifier · 2018-11-25T12:38:00Z

openwisp_utils/qa.py

+        api_title = commit['title']
+
+        if commit['message'] != '':
+            api_message = commit['message'].split("\n")


rename all variables that have the api_ prefix so that they don't have it anymore

nemesifier · 2018-11-25T12:38:43Z

openwisp_utils/qa.py

+        )
+    else:
+        # Check capital after prefix
+        commitMessagefirst = api_title.replace(prefix.group(), '').strip()


do not use camel case variables in python

i'll change

address this comment

nemesifier · 2018-11-25T12:39:50Z

openwisp_utils/qa.py

+# Thank you https://gist.github.com/simonw/091b765a071d1558464371042db3b959
+def _get_commit():
+    leading_4_spaces = re.compile('^    ')
+    lines = _shell_exec('git log -1').split('\n')


I don't think you need to do this, we'll pass output of git log via the bash shell

nemesifier · 2018-11-25T12:40:47Z

openwisp_utils/qa.py

+    # api_token = args.token
+
+    if args.message:
+        api_title = args.message.split("\n")[0]


is api_title the commit short desc?

change all these variable names so they don't mention api anymore, if this is the short desc, name it short_desc, apply the same suggestion to all variables

nemesifier · 2018-11-25T12:43:59Z

tests/test_project/tests/test_qa.py

+            # '--token',
+            # os.environ["GH_TOKEN"],
+            '--repo', os.environ["TRAVIS_REPO_SLUG"],
+            '--message', os.environ['TRAVIS_COMMIT_MESSAGE']


These are all good commit messages, use these ones as starting point

[qa] Minor clean up operations

(it's ok to not reference any issue sometimes)

[qa] Improved Y #2 Related to #2

(but if an issue is mentioned it should be specified whether the commit fixes it or just references it)

[qa] Finished task #2 Closes #2 Related to #1

(multiple references can be added in the extended desc)

These commit messages must not fail.

nemesifier · 2018-11-25T12:47:08Z

tests/test_project/tests/test_qa.py

+                '[qa] Hello World.\nTest\nFixes #20',
+                '--repo', "ppabcd/openwisp-utils"
+            ],
+            ['commitcheck']


other common bad commit messages you should add to the failing tests:

[qa] Finished task X #2 Closes #2

no blank line between short desc and extended desc

nemesifier · 2018-11-25T15:16:21Z

openwisp_utils/qa.py

+                                     "created have a descriptive name. If "
+                                     "default name pattern is found, "
+                                     "raise exception!")
+    parser.add_argument("--token",


shouldn't you remove this?

nemesifier · 2018-11-25T15:16:26Z

openwisp_utils/qa.py

+                        help="Github token for check commit")
+    parser.add_argument("--message",
+                        help="Commit message")
+    parser.add_argument("--repo",


shouldn't you remove this?

nemesifier · 2018-11-25T15:17:06Z

openwisp_utils/qa.py

+    # api_token = args.token
+
+    if args.message:
+        api_title = args.message.split("\n")[0]


change all these variable names so they don't mention api anymore, if this is the short desc, name it short_desc, apply the same suggestion to all variables

nemesifier · 2018-11-25T15:17:14Z

openwisp_utils/qa.py

+        api_title = args.message.split("\n")[0]
+        if len(args.message.split("\n")) > 1:
+            api_message = args.message.split("\n")[1:]
+


remove blank line

nemesifier · 2018-11-25T15:17:17Z

openwisp_utils/qa.py

+    # Check dot in end of the first line
+    if api_title[len(api_title.strip()) - 1].strip() == '.':
+        errors.append("Do not add a final dot at the end of the first line.")
+


remove blank line

nemesifier · 2018-11-25T15:17:31Z

openwisp_utils/qa.py

+        commitMessagefirst = api_title.replace(prefix.group(), '').strip()
+        if not commitMessagefirst[0].isupper():
+            errors.append("No capital letter after prefix")
+


remove blank line

nemesifier · 2018-11-25T15:17:36Z

openwisp_utils/qa.py

+    hastag = re.search(r'\#(\d+)', api_title)
+    if not hastag:
+        errors.append("No mention issues in the short description")
+


remove blank line

nemesifier · 2018-11-25T15:17:41Z

openwisp_utils/qa.py

+            if args.message.split("\n")[1] != '':
+                errors.append("No blank line before first "
+                              "line and second line")
+


remove blank line

nemesifier · 2018-11-25T15:17:46Z

openwisp_utils/qa.py

+            word = parts[num - 2]
+            if word.lower() not in allowed_words:
+                errors.append("Mentions an issue without closing it")
+


remove blank line

nemesifier · 2018-11-25T15:20:07Z

tests/test_project/tests/test_qa.py

+            'commitcheck',
+            '--message',
+            "[qa] Updated more file and fix "
+            "problem #20\n\nAdded more files Fixes #20"


These are all good commit messages, use these ones as starting point

[qa] Minor clean up operations

(it's ok to not reference any issue sometimes)

[qa] Improved Y #2 Related to #2

(but if an issue is mentioned it should be specified whether the commit fixes it or just references it)

[qa] Finished task #2 Closes #2 Related to #1

(multiple references can be added in the extended desc)

These commit messages must not fail, add these to this test case please.

nemesifier

@ppabcd is this ready? Or is it still pending changes?

ppabcd · 2018-11-28T22:53:24Z

ready @nemesisdesign

atb00ker

Please check the comment below. 😄

openwisp_utils/qa.py

ppabcd · 2018-11-30T11:40:53Z

i have done updated description messages @atb00ker

nemesifier

I'm asking these last round of changes and then we are done

nemesifier · 2018-11-30T21:23:26Z

openwisp_utils/qa.py

+        if short_desc_location:
+            # Get all issues in long description
+            long_desc_issues = _check_word(message)
+            if(not _is_array(long_desc_issues)):


rewrite this as if not _is_array(long_desc_issues):

nemesifier · 2018-11-30T21:24:02Z

openwisp_utils/qa.py

+        body = "You have errors with commit message: \n"
+        for e in errors:
+            body += "- " + e + "\n"
+    if(len(errors) > 0):


if len(errors) > 0:

Fixes openwisp#20

ppabcd · 2018-12-01T14:53:34Z

all done @nemesisdesign @atb00ker

Related to #20 Related to #23

nemesifier reviewed Nov 21, 2018

View reviewed changes

ppabcd force-pushed the master branch from f7c74a3 to 76a8c02 Compare November 22, 2018 03:05

nemesifier reviewed Nov 22, 2018

View reviewed changes

ppabcd force-pushed the master branch from 8c40b7a to 8a899aa Compare November 22, 2018 14:52

ppabcd commented Nov 22, 2018

View reviewed changes

nemesifier requested changes Nov 22, 2018

View reviewed changes

ppabcd force-pushed the master branch from e0a57d4 to b75a019 Compare November 23, 2018 16:33

nemesifier requested changes Nov 25, 2018

View reviewed changes

nemesifier reviewed Nov 25, 2018

View reviewed changes

ppabcd force-pushed the master branch 6 times, most recently from b54872c to 9669de8 Compare November 25, 2018 13:50

nemesifier requested changes Nov 25, 2018

View reviewed changes

ppabcd force-pushed the master branch 2 times, most recently from 927355d to 8155e56 Compare November 27, 2018 14:02

atb00ker assigned ppabcd Nov 28, 2018

nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation Nov 28, 2018

nemesifier reviewed Nov 28, 2018

View reviewed changes

atb00ker moved this from To do (general) to In progress in OpenWISP Contributor's Board Nov 29, 2018

atb00ker requested changes Nov 30, 2018

View reviewed changes

openwisp_utils/qa.py Outdated Show resolved Hide resolved

ppabcd force-pushed the master branch 2 times, most recently from fc9ea11 to 51e68e8 Compare November 30, 2018 11:38

nemesifier requested changes Nov 30, 2018

View reviewed changes

[qa] Added commit message check openwisp#20

0c25272

Fixes openwisp#20

ppabcd force-pushed the master branch from 92e8301 to 0c25272 Compare November 30, 2018 22:32

nemesifier added a commit that referenced this pull request Dec 1, 2018

[qa] Improved readability of commit message check #20

cff87d0

Related to #20 Related to #23

nemesifier mentioned this pull request Dec 1, 2018

Improved our quality assurance checks #26

Closed

nemesifier added a commit that referenced this pull request Dec 1, 2018

[ci] Added checkcommit to travis pull request builder #20

d2f44d0

Related to #20 Related to #23

nemesifier added a commit that referenced this pull request Dec 1, 2018

[ci] Added checkcommit to travis pull request builder #20

4a0a4bc

Related to #20 Related to #23

nemesifier added a commit that referenced this pull request Dec 1, 2018

[ci] Added checkcommit to travis pull request builder #20

f4cdc11

Related to #20 Related to #23

nemesifier added a commit that referenced this pull request Dec 1, 2018

[ci] Added checkcommit to travis-ci #20

b89c614

Related to #20 Related to #23

nemesifier added a commit that referenced this pull request Dec 1, 2018

[ci] Added checkcommit to travis build #20

2febfa4

Related to #20 Related to #23

nemesifier mentioned this pull request Dec 1, 2018

[qa] Improved our quality assurance checks #27

Merged

nemesifier added a commit that referenced this pull request Dec 1, 2018

[ci] Added checkcommit to travis build #20

8c7a1bd

Related to #20 Related to #23

nemesifier added a commit that referenced this pull request Dec 1, 2018

[ci] Added checkcommit to travis build #20

db0d3c2

Related to #20 Related to #23

nemesifier added a commit that referenced this pull request Dec 1, 2018

[ci] Added checkcommit to travis build #20

28e177d

Related to #20 Related to #23

nemesifier added a commit that referenced this pull request Dec 1, 2018

[ci] Added checkcommit to travis build #20

20e4174

Related to #20 Related to #23

nemesifier added a commit that referenced this pull request Dec 1, 2018

[ci] Added checkcommit to travis build #20

5cb1a1c

Related to #20 Related to #23

nemesifier merged commit 0c25272 into openwisp:master Dec 2, 2018

OpenWISP Contributor's Board automation moved this from In progress to Done Dec 2, 2018

Added commit message style check #23

Added commit message style check #23

Conversation

ppabcd commented Nov 21, 2018 • edited

coveralls commented Nov 21, 2018

coveralls commented Nov 21, 2018

coveralls commented Nov 21, 2018 • edited

nemesifier left a comment

Choose a reason for hiding this comment

ppabcd commented Nov 21, 2018

KylaCommit commented Nov 22, 2018

atb00ker commented Nov 22, 2018

ppabcd commented Nov 22, 2018 • edited

nemesifier commented Nov 22, 2018

nemesifier left a comment

Choose a reason for hiding this comment

nemesifier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nemesifier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KylaCommit commented Nov 23, 2018

KylaCommit commented Nov 23, 2018

KylaCommit commented Nov 23, 2018

ppabcd commented Nov 23, 2018 • edited

nemesifier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nemesifier left a comment

Choose a reason for hiding this comment

nemesifier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nemesifier Nov 25, 2018 • edited

Choose a reason for hiding this comment

nemesifier left a comment

Choose a reason for hiding this comment

ppabcd commented Nov 28, 2018

atb00ker left a comment

Choose a reason for hiding this comment

ppabcd commented Nov 30, 2018

nemesifier left a comment

ppabcd commented Nov 21, 2018 •

edited

coveralls commented Nov 21, 2018 •

edited

ppabcd commented Nov 22, 2018 •

edited

ppabcd commented Nov 23, 2018 •

edited

nemesifier Nov 25, 2018 •

edited