Improved our quality assurance checks #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added this option in case we run into some unplanned issue in the future, this will help to avoid having to block pull requests. We may remove this option once we are confident in the "checkcommit" implementation.
nemesifier
force-pushed
the
qa
branch
3 times, most recently
from
f4cdc11
to
b89c614
Compare
|
Damn, the travis build has gotten stuck and I cannot restart it. I will try to close this and re-open it. |
|
Didn't work. I will try to open a new one 😠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ppabcd see the improvements to your code, especially regarding readability
@atb00ker I found out a few things that needed improvement in the migration check as well, these kind of checks are designed to be used as linux commands so they should not raise exceptions in case of failure but simply print a message and exit with an exit code higher than zero.
I've added some basic docs in the readme and last but not least I've added a way to skip the commit message check (using the
#noqakeyword in the commit message) in case we encounter some legit case which we didn't plan here and we don't want to block the build, we may remove this option in the future once we are confident all cases are covered.Related to #20 and #23.