Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Homepage charts and login on small screens #275 #276

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

Aryamanz29
Copy link
Member

@Aryamanz29 Aryamanz29 commented Jan 27, 2022

Fixes #275

Changes

Fix charts and login on small screens ( Samsung s8+, IPhone SE etc)

Screenshots

openwisp-utils

Screenshot from 2022-01-27 12-55-13

Screenshot from 2022-01-27 00-36-12

openwisp-monitoring

Screenshot from 2022-01-26 22-58-56

Checklist

  • I have read the contributing guidelines.
  • I have manually tested the proposed changes.
  • I have written new test cases to avoid regressions. (if necessary)
  • I have updated the documentation. (e.g. README.rst)
  • I have added [change!] to commit title to indicate a backward incompatible change. (if required)
  • I have checked the links added / modified in the documentation.

@Aryamanz29 Aryamanz29 force-pushed the issue-275/homepage-chart-login branch from f84e62d to 71aff27 Compare January 27, 2022 08:47
@Aryamanz29 Aryamanz29 changed the title [fix] homepage charts and login on small screens #275 [fix] Homepage charts and login on small screens #275 Jan 27, 2022
@coveralls
Copy link

coveralls commented Jan 27, 2022

Coverage Status

Coverage remained the same at 98.618% when pulling 9097610 on Aryamanz29:issue-275/homepage-chart-login into deb4af2 on openwisp:master.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can avoid using !Important would be great (without complicating too much).

}
.menu-bar{
width: 280px !important;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems this block can be removed, please double check


.login #container {
width: auto !important;
max-width: 280px !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also may be removed (because it will fallback to 300px which is not that different), however, the logo needs to be centered properly.

Comment on lines 1606 to 1608
.menu-bar{
width: 280px !important;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causing login screen logo misalignment, After removing it looks like this 👇

Screenshot from 2022-02-12 15-49-27

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nemesifier nemesifier merged commit 0ef9714 into openwisp:master Feb 12, 2022
@Aryamanz29 Aryamanz29 deleted the issue-275/homepage-chart-login branch February 17, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] homepage pie charts and login screen not centered on mobile
3 participants