Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wifi-login-pages] Set page title #155

Closed
nemesifier opened this issue Jan 26, 2021 · 2 comments · Fixed by #268
Closed

[wifi-login-pages] Set page title #155

nemesifier opened this issue Jan 26, 2021 · 2 comments · Fixed by #268
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nemesifier
Copy link
Member

nemesifier commented Jan 26, 2021

For each page of the app we should have a title, eg: {page_title} - {organization_name}.

We should have a title attribute in the org-config of each component, translatable, eg:

registration_form:
    title:
        en: "Sign up"

We should add a test for each component to ensure the tile is changed as expected.

Also the main title should be allowed to be multilingual, now we have:

client:
  # <title> value
  title: "WiFi Login"

we shall switch to:

client:
  # <title> value
  title:
    en: "WiFi Login"
    it: "Accesso WiFi"
    # other languages...
@nemesifier nemesifier added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 26, 2021
@sankha555
Copy link

I am working on this

@jalajcodes
Copy link

jalajcodes commented Feb 21, 2021

As Sankha's pr doesn't fix this issue, I am working on it.

codesankalp added a commit that referenced this issue Jun 12, 2021
Added translatable support for page title in each page.

Closes #155
codesankalp added a commit that referenced this issue Jun 12, 2021
Added translatable support for page title in each page.

Closes #155
codesankalp added a commit that referenced this issue Jun 20, 2021
Added translatable support for page title in each page.

Closes #155
nemesifier pushed a commit that referenced this issue Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
3 participants