[readme] Update readme #57 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoumbissiValere
force-pushed
the
issue-57-update-readme
branch
from
acd0a04
to
0363b2e
Compare
NoumbissiValere
moved this from In progress
to Needs review
in OpenWISP Priorities for next releases
atb00ker
reviewed
Nov 8, 2020
| @@ -29,14 +29,46 @@ Openwisp wifi login pages app to allow users to authenticate, sign up and know m | |||
|
|
|||
| ### Install | |||
|
|
|||
| ##### Clone this repo | |||
| #### Install openwisp-radius | |||
There was a problem hiding this comment.
@NoumbissiValere Is it possible to give the user the installation instructions from openwisp-radius docs?
This will enable our docs to be more DRY, i.e: when a change is made in installation process, we would not need to update here as well.
Also, that documentation is more verbose! 😄
What do you think?
There was a problem hiding this comment.
You are very correct @atb00ker 👍
NoumbissiValere
force-pushed
the
issue-57-update-readme
branch
3 times, most recently
from
a339827
to
4ab7d5e
Compare
Fixes #57
NoumbissiValere
force-pushed
the
issue-57-update-readme
branch
from
4ab7d5e
to
6ec0cf0
Compare
nemesifier
approved these changes
Nov 9, 2020
OpenWISP Priorities for next releases
automation
moved this from Needs review
to Reviewer approved
Nov 9, 2020
OpenWISP Priorities for next releases
automation
moved this from Reviewer approved
to Done
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #57