Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Added server side logging #244

Merged
merged 3 commits into from May 28, 2021
Merged

[feature] Added server side logging #244

merged 3 commits into from May 28, 2021

Conversation

codesankalp
Copy link
Member

Closes #82

Tasks done:

  • Added Winston for logging
  • Integrated morgan with Winston to log HTTP requests
  • Removed checking for status code to handle timeout error and connection refused error.

@codesankalp codesankalp added this to Review in progress in [GSoC 2021] wifi-login-pages May 25, 2021
nemesifier
nemesifier requested changes May 26, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
server/loggerConfig.js Show resolved Hide resolved
@codesankalp codesankalp mentioned this pull request May 26, 2021
Merged
[GSoC 2021] wifi-login-pages automation moved this from Review in progress to Reviewer approved May 28, 2021
@nemesifier nemesifier merged commit 157cf72 into master May 28, 2021
[GSoC 2021] wifi-login-pages automation moved this from Reviewer approved to Done May 28, 2021
@nemesifier nemesifier deleted the issue-82-server-logger branch May 28, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees

@codesankalp codesankalp

Labels
None yet
Projects
No open projects
[GSoC 2021] wifi-login-pages
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wifi-login-pages] Add server side logging (nodejs)
2 participants
@codesankalp @nemesifier