[feature] Added option to show user's data usage on status page #735 #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
issues/735-user-usage
branch
4 times, most recently
from
706fdb3
to
568b9d1
Compare
pandafy
force-pushed
the
issues/735-user-usage
branch
3 times, most recently
from
78443c1
to
210f5bc
Compare
pandafy
force-pushed
the
issues/735-user-usage
branch
2 times, most recently
from
f199c26
to
cb517a0
Compare
nemesifier
reviewed
Jan 10, 2024
nemesifier
requested changes
Jan 12, 2024
client/components/status/status.js
Outdated
Comment on lines
790
to
822
| {bytes(session.input_octets, { | ||
| decimalPlaces: 0, | ||
| unitSeparator: " ", | ||
| unit: "MB", | ||
| })} | ||
| {bytes(session.output_octets, { | ||
| decimalPlaces: 0, | ||
| unitSeparator: " ", | ||
| unit: "MB", | ||
| })} | ||
| </td> |
There was a problem hiding this comment.
I think there's a bug here, this is the result on a narrow screen:
I think session.output_octets must be removed here.
pandafy
force-pushed
the
issues/735-user-usage
branch
from
ee39d09
to
70ae38b
Compare
nemesifier
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Try the following:
- log in
- exhaust traffic
- log out and click on yes on the remember me question
- reset the session traffic in the backend to obtain again zero traffic
- click on log in again
Expected result: no exhausted message is visible.
Actual result: exhausted message is visibile.
nemesifier
requested changes
Feb 10, 2024
i18n/it.po
Outdated
| @@ -520,6 +524,26 @@ msgstr "Log out effettuato con successo" | |||
| msgid "PASSWORD_EXPIRED" | |||
| msgstr "La tua password è scaduta, aggiornala." | |||
|
|
|||
| #: client/components/status/status.js:384 | |||
| msgid "SUCCESS_UPGRADE_PLAN" | |||
| msgstr "Piano di aggiornamento in corso" | |||
There was a problem hiding this comment.
Suggested change
| msgstr "Piano di aggiornamento in corso" | |
| msgstr "Ricarica in corso" |
i18n/it.po
Outdated
|
|
||
| #: client/components/status/status.js:964 | ||
| msgid "PLAN_UPGRADE_BTN_TXT" | ||
| msgstr "Aggiornamento" |
There was a problem hiding this comment.
Suggested change
| msgstr "Aggiornamento" | |
| msgstr "Ricarica" |
i18n/it.po
Outdated
|
|
||
| #: client/components/status/status.js:1000 | ||
| msgid "USAGE_LIMIT_EXHAUSTED_TXT" | ||
| msgstr "Hai esaurito il traffico disponibile. Esegui l'upgrade per continuare a utilizzare il servizio." |
There was a problem hiding this comment.
Suggested change
| msgstr "Hai esaurito il traffico disponibile. Esegui l'upgrade per continuare a utilizzare il servizio." | |
| msgstr "Hai esaurito il traffico disponibile. Effettua una ricarica per continuare a utilizzare il servizio." |
i18n/it.po
Outdated
|
|
||
| #: client/components/status/status.js:964 | ||
| msgid "PLAN_EXHAUSTED_TOAST" | ||
| msgstr "Hai esaurito il traffico disponibile sul tuo pacchetto." |
There was a problem hiding this comment.
Suggested change
| msgstr "Hai esaurito il traffico disponibile sul tuo pacchetto." | |
| msgstr "Hai esaurito il traffico disponibile nel tuo abbonamento." |
When subscriptions module is used, show user's current plan. If user's current plan is free, then show option to upgrade the plan. Closes #735
- Changed getUserRadiusUsage refresh interval to 2 minutes - Don't show "Wifi Session Logged in" message if the user has exhausted there plan - Only show plan exhausted message if the subscription module is in use
pandafy
force-pushed
the
issues/735-user-usage
branch
from
dfc0444
to
465a946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subscriptions module is used, show user's current plan. If user's current plan is free, then show option to upgrade the plan.
Closes #735
Closes #736
TODOS