Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change label that also DEM certificate format is permitted #4248

Closed
ChrisEt opened this issue Jul 9, 2020 · 0 comments
Closed

Change label that also DEM certificate format is permitted #4248

ChrisEt opened this issue Jul 9, 2020 · 0 comments

Comments

@ChrisEt
Copy link

ChrisEt commented Jul 9, 2020

On the luci configuration page Services / uhttpd the fields for choosing the certificate and private key are labeled HTTPS Certificate (DER Encoded) and HTTPS Private Key (DER Encoded). This is misleading because uhttpd also accepts the PEM format.

The problem is that the DER format cannot contain a certificate chain. This is no issue for self-signed certificates, but a big problem for CA-signed ones. That's why the PEM format is needed.

I found this ticket where the PEM support has been added: https://dev.archive.openwrt.org/ticket/12457
and this ticket where someone had a similar problem: openwrt/packages#2797

I suggest to simply change the labels on the web page to something like: "HTTPS Certificate (DER or PEM format)"
@atiensivu atiensivu mentioned this issue Jul 12, 2020
Closed
atiensivu added a commit to atiensivu/luci that referenced this issue Jul 12, 2020
@atiensivu
Issue openwrt#4248 fix - 'DER format' to 'DER or PEM'
be601a1 
Easy fix for the requested change.

Clarify DER support as having DER and PEM support, which it does, as of recently.

Direct result of issue openwrt#4248's request.

Signed-off-by: Aaron Tiensivu <atiensivu@gmail.com>
atiensivu added a commit to atiensivu/luci that referenced this issue Jul 13, 2020
@atiensivu
Revert "Issue openwrt#4248 fix - 'DER format' to 'DER or PEM'"
17d023b 
This reverts commit be601a1.
atiensivu added a commit to atiensivu/luci that referenced this issue Jul 13, 2020
@atiensivu
Revert "Revert "Issue openwrt#4248 fix - 'DER format' to 'DER or PEM'""
8fbdd6e 
This reverts commit 17d023b.
atiensivu added a commit to atiensivu/luci that referenced this issue Jul 13, 2020
@atiensivu
luci-app-uhttpd: fix translation for key option
a41b1e3 
Clarify DER support as having DER and PEM support, as of recently.
Direct result of issue openwrt#4248's request.

Signed-off-by: Aaron Tiensivu <atiensivu@gmail.com>
atiensivu added a commit to atiensivu/luci that referenced this issue Jul 13, 2020
@atiensivu
luci-app-uhttpd: fix translation for key option
c9b6b44 
Clarify DER support as having DER and PEM support, as of recently.
Direct result of issue openwrt#4248's request.

Signed-off-by: Aaron Tiensivu <atiensivu@gmail.com>
Signed-off-by: Aaron Tiensivu <atiensivu@users.noreply.github.com>
atiensivu added a commit to atiensivu/luci that referenced this issue Jul 13, 2020
@atiensivu
Revert "Issue openwrt#4248 fix - 'DER format' to 'DER or PEM'"
edba958 
This reverts commit be601a1.

Signed-off-by: Aaron Tiensivu <atiensivu@users.noreply.github.com>
atiensivu added a commit to atiensivu/luci that referenced this issue Jul 13, 2020
@atiensivu
Revert "Revert "Issue openwrt#4248 fix - 'DER format' to 'DER or PEM'""
0f9715b 
This reverts commit 17d023b.

Signed-off-by: Aaron Tiensivu <atiensivu@users.noreply.github.com>
atiensivu added a commit to atiensivu/luci that referenced this issue Jul 20, 2020
@atiensivu
luci-app-uhttpd: fix translation for key option
d662f3c 
Clarify DER support as having DER and PEM support.
Issue openwrt#4248's request.

Signed-off-by: Aaron Tiensivu <atiensivu@users.noreply.github.com>
@atiensivu atiensivu mentioned this issue Jul 20, 2020
Merged
@feckert feckert closed this as completed Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

luci-app-uhttpd: fix translation for key option atiensivu/luci
2 participants
@feckert @ChrisEt