Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu after logging in #4467

Closed
thedyerman opened this issue Sep 23, 2020 · 3 comments
Closed

Menu after logging in #4467

thedyerman opened this issue Sep 23, 2020 · 3 comments

Comments

@thedyerman
Copy link

thedyerman commented Sep 23, 2020

Menu is causing some type of timeout when first logging into LUCI interface.
Running commit b17ec09 but has been an issue for the last few.

image

Easily recreate it by logging out and back into interface (default or material theme), happens every time across multiple routers I have running (all MediaTek although I'm not sure that's relevant)

@rmilecki
Copy link

According to my bisecting & testing this issue is caused by the 5e9c23c6f40f ("client: allow keep-alive for POST requests").

I don't know much about keep-alive, it seems like some problem with uhttp's connection closing (or just letting client know about end of file?). Sometimes it hits the menu resource, another time fs.js.

@rmilecki
Copy link

Jo pointed out that above commit is quite old while LuCI was working fine few weeks ago. So there had to be some interference of at least two changes.

I keep bisecting and I noticed that uhttpd regression (described above) was exposed by my LuCI commit bc6e4df ("luci-base: use actual JSON-RPC for verifying ubus RPC URL"). It cannot be simply reverted as it will break LuCI due to the uhttpd change adding new API.

@olimpiumarius
Copy link
Contributor

olimpiumarius commented Oct 3, 2020

Capture1 (1)
Capture3
Capture2

1715173329 pushed a commit to immortalwrt/immortalwrt that referenced this issue Oct 5, 2020
14a3cb4 ubus: fix legacy empty reply format
0f38b03 client: fix spurious keepalive connection timeouts
88ba2fa client: really close connection on timeout
c186212 ubus: support GET method with CORS requests

Fixes: FS#3369
Fixes: openwrt/luci#4467
Fixes: openwrt/luci#4470
Fixes: openwrt/luci#4479
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jollaman999 pushed a commit to jollaman999/openwrt that referenced this issue Oct 7, 2020
14a3cb4 ubus: fix legacy empty reply format
0f38b03 client: fix spurious keepalive connection timeouts
88ba2fa client: really close connection on timeout
c186212 ubus: support GET method with CORS requests

Fixes: FS#3369
Fixes: openwrt/luci#4467
Fixes: openwrt/luci#4470
Fixes: openwrt/luci#4479
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
cstkingkey pushed a commit to cstkingkey/lede that referenced this issue Feb 22, 2021
14a3cb4 ubus: fix legacy empty reply format
0f38b03 client: fix spurious keepalive connection timeouts
88ba2fa client: really close connection on timeout
c186212 ubus: support GET method with CORS requests

Fixes: FS#3369
Fixes: openwrt/luci#4467
Fixes: openwrt/luci#4470
Fixes: openwrt/luci#4479
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants