Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ksmb app no longer works, impossible to create network shares #4470

Closed
borkra opened this issue Sep 25, 2020 · 4 comments
Closed

ksmb app no longer works, impossible to create network shares #4470

borkra opened this issue Sep 25, 2020 · 4 comments

Comments

@borkra
Copy link

borkra commented Sep 25, 2020

  • Form to enter share information not visible
  • Hitting save on the form result in "Unexpected reply data format." message
@jow-
Copy link
Contributor

jow- commented Sep 25, 2020

  • Please mention the exact version of LuCI you're running (opkg list-installed luci-base)
  • Please mention the exact version of uhttpd (opkg list-installed uhttpd)
  • Please try commenting out option ubus_prefix '/ubus' in /etc/config/uhttpd, restart uhttpd, close and reopen the LuCI browser tab or try logging in using an incognito window and see if the issue persists.

@borkra
Copy link
Author

borkra commented Sep 25, 2020

@jow Version everything master, fetched from git and rebuilt everything yesterday evening.

luci-base - git-20.267.53658-b17ec09
uhttpd - 2020-09-18-47c34bd6-1

Commenting out "option ubus_prefix '/ubus'" fixes ksmbd

One more issue constant hangs after login, logout and few other pages. If wait long enough get "XHR request timed out"
Tried with browser Firefox 81 and Edge/Chrome 85, on Linux and Windows.

With commented "option ubus_prefix '/ubus'", get "No related RPC reply" message on Log In and Log Out, and maybe other screens, and no hang any more

@borkra
Copy link
Author

borkra commented Oct 4, 2020

It looks like this commit causing the issue:
https://git.openwrt.org/?p=project/uhttpd.git;a=commit;h=11723570af9cb7bd87842e79c85ee99530be9902

Reverting uhttpd to the 2020-08-05 version fixes the problem.

Most like likely this hack does not cover all cases:

+       /* Treat both: /foo AND /foo/ as legacy requests. */
+       if (ops->path_match(conf.ubus_prefix, url) && strlen(url) - strlen(conf.ubus_prefix) <= 1) {
+               du->legacy = true;
+               uh_ubus_data_done(cl);
+               return;
+       }

@borkra
Copy link
Author

borkra commented Oct 4, 2020

@rmilecki could you please look into this uhttpd issue

1715173329 pushed a commit to immortalwrt/immortalwrt that referenced this issue Oct 5, 2020
14a3cb4 ubus: fix legacy empty reply format
0f38b03 client: fix spurious keepalive connection timeouts
88ba2fa client: really close connection on timeout
c186212 ubus: support GET method with CORS requests

Fixes: FS#3369
Fixes: openwrt/luci#4467
Fixes: openwrt/luci#4470
Fixes: openwrt/luci#4479
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jollaman999 pushed a commit to jollaman999/openwrt that referenced this issue Oct 7, 2020
14a3cb4 ubus: fix legacy empty reply format
0f38b03 client: fix spurious keepalive connection timeouts
88ba2fa client: really close connection on timeout
c186212 ubus: support GET method with CORS requests

Fixes: FS#3369
Fixes: openwrt/luci#4467
Fixes: openwrt/luci#4470
Fixes: openwrt/luci#4479
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
cstkingkey pushed a commit to cstkingkey/lede that referenced this issue Feb 22, 2021
14a3cb4 ubus: fix legacy empty reply format
0f38b03 client: fix spurious keepalive connection timeouts
88ba2fa client: really close connection on timeout
c186212 ubus: support GET method with CORS requests

Fixes: FS#3369
Fixes: openwrt/luci#4467
Fixes: openwrt/luci#4470
Fixes: openwrt/luci#4479
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants