New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-commands: fix incorrect url generation. #1244

Closed
wants to merge 1 commit into
from
Jump to file or symbol
Failed to load files and symbols.
+1 −2
Diff settings

Always

Just for now

@@ -109,8 +109,7 @@
if (legend && output)
{
var prefix = location.protocol + '//' + location.hostname +
(location.port ? ':' + location.port : '') +
location.pathname.split(';')[0] + 'command/';
(location.port ? ':' + location.port : '') + '<%=url('command')%>/';

This comment has been minimized.

@yousong

yousong Jan 27, 2018

Member

Sorry for the delay. Please also sign off the commit as required by the CONTRIBUTING.md guide.

While at it, can you also tuck the ending slash / inside the url() call, like url('command/')? Thank you

@yousong

yousong Jan 27, 2018

Member

Sorry for the delay. Please also sign off the commit as required by the CONTRIBUTING.md guide.

While at it, can you also tuck the ending slash / inside the url() call, like url('command/')? Thank you

var suffix = (args ? '/' + args : '');
var link = prefix + id + suffix;